This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
demo: move mesh delete command into the cleanup script #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful to run the cleanup script by itself. The mesh delete command must also be run to cleanup mesh resources created by install. This change moves the mesh delete command into the cleanup script so that this single cleanup script can be used to clean up all resources deployed by the demo. Signed-off-by: Shashank Ram <shashank08@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1831 +/- ##
==========================================
+ Coverage 59.09% 59.21% +0.11%
==========================================
Files 125 125
Lines 5171 5171
==========================================
+ Hits 3056 3062 +6
+ Misses 2112 2106 -6
Partials 3 3
Continue to review full report at Codecov.
|
michelleN
reviewed
Oct 14, 2020
| @@ -5,6 +5,8 @@ set -aueo pipefail | |||
| # shellcheck disable=SC1091 | |||
| source .env | |||
|
|
|||
| bin/osm mesh uninstall -f --mesh-name "$MESH_NAME" --namespace "$K8S_NAMESPACE" | |||
There was a problem hiding this comment.
Should we add a make build-osm before running the uninstall command?
There was a problem hiding this comment.
We could but unnecessary in the context of current usage (always invoked via demo script). Is it ok to assume the cleanup script for the demo is run post install, at which time the cli binary is built already? I don't see value in even running this without the demo being run prior.
michelleN
approved these changes
Oct 14, 2020
nojnhuh
approved these changes
Oct 14, 2020
eduser25
pushed a commit
to eduser25/osm
that referenced
this pull request
Oct 14, 2020
…sh#1831) It is useful to run the cleanup script by itself. The mesh delete command must also be run to cleanup mesh resources created by install. This change moves the mesh delete command into the cleanup script so that this single cleanup script can be used to clean up all resources deployed by the demo. Signed-off-by: Shashank Ram <shashank08@gmail.com>
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
…sh#1831) It is useful to run the cleanup script by itself. The mesh delete command must also be run to cleanup mesh resources created by install. This change moves the mesh delete command into the cleanup script so that this single cleanup script can be used to clean up all resources deployed by the demo. Signed-off-by: Shashank Ram <shashank08@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It is useful to run the cleanup script by itself. The mesh
delete command must also be run to cleanup mesh resources
created by install. This change moves the mesh delete command
into the cleanup script so that this single cleanup script
can be used to clean up all resources deployed by the demo.
Affected area:
Please answer the following questions with yes/no.
No