fix: pasting a component with image isn't working#8
Merged
Faraz32123 merged 1 commit intorelease-ulmofrom Oct 23, 2025
Merged
Conversation
- when copying a component that has image in it, and we try to paste it. Image URL appends `static_None`. Result in crash or image not found error. - In this commit we have fixed this scenario, copy paste is working for components containing images.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where pasting a component containing an image results in image URLs being corrupted with static_None, causing crashes or image not found errors. The fix prevents unnecessary URL substitutions when the file already exists with matching content.
Key Changes:
- Modified the return value when an existing file with matching content is detected to avoid incorrect path substitutions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Faraz32123
requested review from
djoseph-apphelix,
jristau1984,
papphelix,
pganesh-apphelix,
rayzhou-bit and
viv-helix
papphelix
approved these changes
Oct 23, 2025
This was referenced Oct 23, 2025
timmc-edx
pushed a commit
that referenced
this pull request
Oct 24, 2025
…_edx fix: pasting a component with image isn't working
Member
|
Historical note: We rewrote release-ulmo, and the merge commit for this PR was rewritten to ec3639e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: TNL2-394
When copying a component that has image in it, and we try to paste it. Image URL appends
static_None. Result in crash or image not found error.Before:
mfe.before.mov
before.mov
After:
mfe.after.mov
after.mov