Fix/copy paste component with image for edx #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 5. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…downstream_parent_key (openedx#37448) * refactor!: use String field instead of Dict field to store top_level_downstream_parent_key Since this is a new field no production instance should have this field yet. Developers need to delete their old courses as this change will raise error in all course pages. * chore: add `top_level_parent` field in ComponentLink and ContainerLink admin * refactor: use ":" as separator * refactor: block key parsing and tests
This came from a github security advisory suggestion but makes sense given that this workflow dosen't need to push content back. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
The announcements editor was never ported to frontend-app-authoring, and the announcements display was never ported to frontend-app-learner-dashboard. This announcements feature is rarely used, undocumented, non-a11y-friendly, and there were no volunteers to port it to the new frontends. It is the last remaining part of the legacy Studio "Maintenance" dashboard. So, we are removing it. BREAKING CHANGE: This removes... * Studio Maintenance dashboard legacy frontend * Studio Edit Announcements legacy frontend * The snippet of legacy learner dashboard which renders announcements * openedx/features/announcements djangoapp * The ENABLE_ANNOUNCEMENTS feature flag Not removed: * The announcements_announcement table from openedx/features/announcements . The table is most likely very small, as it is only populated by administrators. Removing it would be more labor for us and more risk of toil for operators than is worthwhile. Closes: openedx#36263
Co-authored-by: Іван Нєдєльніцев <ivan.niedielnitsev@raccoongang.com> Co-authored-by: Kyrylo Kholodenko <kyrylo.kholodenko@raccoongang.com> Co-authored-by: Glib Glugovskiy <glib.glugovskiy@raccoongang.com>
feat: add an endpoint to create a customer admin user Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
- Adds the task, python api, and rest api view for bulk migration. - Refactor the code to share code between single migration and bulk migration.
feat: add an endpoint to create a customer admin user Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
…s-subset-depr fix: replace deprecated assertDictContainsSubset()
The code that renders these was removed some time ago but this got missed I guess. This cleanup is part of openedx#36108 and openedx-unsupported/studio-frontend#381
…lity_html fix: Remove templates that are never used.
…enedx#37433) * Which edX user roles will this change impact? "Developer"". * Added `upstream_ready_to_sync_children_info` in `ContainerChildrenSerializer` * Now, the `ContainerChildrenView` can return the `upstream_ready_to_sync_children_info` * Update the child info in `UpstreamLink._check_children_ready_to_sync`
build: enable CI checks in merge queues / merge groups on GitHub
chore: bump edxval to 3.1.0 (openedx#37490)
Bumps [thollander/actions-comment-pull-request](https://github.com/thollander/actions-comment-pull-request) from 2 to 3. - [Release notes](https://github.com/thollander/actions-comment-pull-request/releases) - [Commits](thollander/actions-comment-pull-request@v2...v3) --- updated-dependencies: - dependency-name: thollander/actions-comment-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Remove the flag and update the code paths as if it's always set to true.
And update the studio-view function to raise a NotImplementedError since we now rely on the authoring environment to provide the edit view of this block. Unfortunately, a copy of the template lives in the lms and relies on the the underlying JS and CSS to render a tiny-mce editor in the instructor dashboard. This means we can't remove the CSS and JS until we've dropped the usage of it in the instructor dash. The good news is, that the work to replace the instructor dash is in progress so those assets should get cleaned up soon. The places where the JS and CSS is still being used are: * lms/templates/instructor/instructor_dashboard_2/instructor_dashboard_2.html * lms/djangoapps/instructor/views/instructor_dashboard.py
* feat: show item bank ui for migrated legacy library content * feat: migrate legacy content block to item bank block on view in studio * fix: duplicate and copy issues * refactor: migration location and add tests * fix: lint issues * fix: item bank and library content children view add button functionality Newly added blocks from library in children view page of item bank block and migrated library content block were not displayed automatically. * fix: lint issues * fix: lint issues * feat: only migrate if same version of library is migrated * refactor: migrate block on request * fix: component reload on migration * fix: tests * refactor: comments and message wordings * refactor: update alert text * docs: add context * fix: component links not being created on migrating legacy blocks * fix: api docs and types * refactor: use inheritance and specific parent method call * fix: imports * fix: api typing * fix: upstream_version check * refactor: rename variables * refactor: parsing entity keys to usage_keys
…enterprise-e2526cf feat: Upgrade Python dependency edx-enterprise
…-errant-string fix: prevent errant body string on title edit
Co-authored-by: Kyle McCormick <kyle@axim.org>
This page has been replaced with an equivalent page in the authoring MFE which has been on by default since Teak. This change removes the ability to fallback to the old page using waffle flags. BREAKING CHANGE: The `legacy_studio.course_outline` waffle flag will be removed and the code will behave as if it's always set to `False`. Preventing you from falling back to the old Course Outline page.
The tests were testing a set of menu items that were specifically available on the old course_outline page. Since the page is never rendered we don't need to test to see if those header items are actually rendered. As we finish the rest of the studio frontend cleanup, the header itself should be removed but just removing these tests since they relied on conditional bits of the header for when it was showing a course outline.
The removed tests either needed to check things on the outline page which makes them not relevant tests, or they just needed data from the course_handler which they can get from json now.
Co-authored-by: Kyle McCormick <kyle@axim.org>
The behavior of the MariaDB backend has changed behavior for UUIDField from a `CharField(32)` to an actual `uuid` type. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual tring being written is a UUID with the `-` included, resulting in a 36 character value which can't be inserted into a 32 character column.
The ContentLibraryMetadata used to hold a version field that was meant to represent the version of the library as a whole. This is a holdover from v1 libraries, where all changes to the library resulted in a new version of the content, and that version indicator was used by courses to know whether or not an update was available. This maps poorly to Learning Core backed libraries for a number of reasons: 1. LC-backed libraries have Draft and Published branches, meaning that a global "version" may be ambiguous. 2. LC-backed libraries have things like tagging and collections, where modifications are explicitly *not* versioned at all, and do not show up in either the publish log or the draft change log. 3. Courses that borrow content from LC-backed libraries track versioning at the level of the individual thing being borrowed, e.g. a single Component. This is in keeping with the goal to have very large libraries with many small bits of content to search and use. This commit removes the notion of a Library-global version entirely for v2 (LC-backed) libraries. This does not affect legacy v1 libraries that are backed by ModuleStore.
feat!: Drop the legacy studio course home page
feat!: Drop the legacy course_outline page.
The assets page and related tests and settings flags will be removed. They have been replaced with a new implementation in the frontend-app-authoring MFE. BREAKING CHANGE: The legacy_studio.files_uploads flag has been removed and will no longer allow operators to fall back to the legacy files and uploads view. The new MFE version is now the only available veiew.
This check was previously only running on PRs to master, which makes it annoying to stack PRs and have all the checks run. Update it so that the check runs on all PRs and on pushes to master.
…ggers build: Fix workflow triggers for the Dunder init check.
…files feat!: Drop the legacy files and uploads page.
The dependencies on this package via studio should all be removed now and so we no longer need to install this package to pickup any components from it. This work is part of: * openedx#36275 * openedx#36108
Drop tooling to load studio-frontend components into mako templates and XSS testing features related to it.
…tend_dependency build: Don't install @edx/studio-frontend
…saction [FC-0097] (openedx#37485) - `handle_update_xblock_upstream_link` is called asynchronously with celery. In `update_upstream_downstream_link_handler`, the xblock has the updated version, but when calling `handle_update_xblock_upstream_link` inside Celery, the xblock is outdated in a previous version, which is why the error occurs. This happens because `on_commit_changes_to` is executed before the MySQL transaction ends. - Added `ImmediateOnCommitMixin` to be used in tests that need to call `on_commit_changes_to`. See openedx#37485 (comment) for more info
…edx#37508) The 'url' field on the GET /api/libraries/v2/{library_id}/backup/?task_id={task_id} endpoint was returning realtive paths when the file was stored on the default FileSystemStorage backend, which makes it inconsistent with other storage backends and semantically incorrect. This commit addresses this making sure it always returns an absolute url.
chore: sync upgrade django 5.2
- when copying a component that has image in it, and we try to paste it. Image URL appends `static_None`. Result in crash or image not found error. - In this commit we have fixed this scenario, copy paste is working for components containing images.
|
Thank you for your pull request! Congratulations on completing the Open edX tutorial! A team member will be by to take a look shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous related PR: #8
upstream PR: openedx#37529.