Skip to content

Conversation

@b-studios
Copy link
Collaborator

This replaces #432 and backports its changes on top of #449.

@b-studios b-studios mentioned this pull request May 24, 2024
@@ -1,5 +1,9 @@
; Run-Time System

attributes #0 = { "ccc" }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phischu I added this in experiments of trying to fix the calling convention. Either we annotate it everywhere where we call into c or drop it here. What do you think?

@b-studios b-studios requested a review from phischu June 6, 2024 15:23
@b-studios
Copy link
Collaborator Author

b-studios commented Jun 6, 2024

I think this is finally ready for review; @phischu there are still some things we need to address (potentially after this PR):

  • consistently naming functions and types within C and LLVM (I would need your input there)
  • fixing Buffer to be a Pos
  • adding more features to files, network, and console to LLVM (this can be done after merging this PR)
  • deciding which of the 3 buffer implementations we now want (also after this PR)
  • make error reporting consistent across all file operations. Also allow promises to take errors (also this I would prefer to do after the PR is merged).
  • implement concurrent IO for other backends

@b-studios b-studios merged commit 47cb0d0 into master Jun 7, 2024
@b-studios b-studios deleted the backport-concurrent-io branch June 7, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants