Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When powershell scripts fail they should abort execution #243

Closed
RandomSort opened this issue May 6, 2020 · 0 comments · Fixed by #266
Closed

When powershell scripts fail they should abort execution #243

RandomSort opened this issue May 6, 2020 · 0 comments · Fixed by #266

Comments

@RandomSort
Copy link
Contributor

If you run the setup.ps1 script, and it can't delete the exercise folder. It will do some Git commands in the kata repository.

Rather it should fail gracefully.
This was referenced Jun 9, 2020
Closed
Merged
RandomSort pushed a commit that referenced this issue Jul 1, 2020
@bothzoli @RandomSort
Gracefully fail when removing exercises folder
b44b2c9 
If for whatever reason the `exercises` folder cannot be removed the
`setup.ps1` script did not stop but continue running potentionally
spilling a lot of error messages.
With this change the failing deletion will stop the setup script.

Resolves: #243
RandomSort pushed a commit that referenced this issue Jul 1, 2020
@bothzoli @RandomSort
Further improve error handling in setup.ps1
98d531e 
Resolves: #243
farzanahmad863 added a commit to farzanahmad863/git-katas that referenced this issue Oct 7, 2020
@farzanahmad863 @RandomSort
@JKrag @ftheile @adamatan @ntnhon @sofusalbertsen @quartercastle @grammeaway @atombrella @brent-clark-SED-Sw-Mgr @Natasha2001 @alxb5 @schiluveri @bothzoli @joachimbulow @EfiGaja @bicschneider
Update from original (#1)
c0630aa 
* Fix typos

* Remove usage of patch mode add from 3-way-merge exercise

Patch mode add is an advanced topic that does not fit the level of this
exercise and the time and way it is typically used in training.

* Add a bare minimum shell survival guide for training

* Add more editor config options to basic-commits

Instructions for Atom and Notepad++

* Fixed commit -m example

* Remove --decorate from katas

The --decorate option is default in git log, and provides no value in
the form where it is currently used in the examples.

* Mention `touch` to create an empty file

* Update SHELL-BASICS.md

Added elaboration

* Fix a typo: append missing closing brace

* Style: mark 'file.txt' as code

* Fix typos

* Adding note about running sh in windows
FIX  eficode-academy#183

* Mark "git status" as code

* Add learning path to README

Close eficode-academy#185 close eficode-academy#130 close eficode-academy#56

* setup.sh and verify.sh should be executables

* Fixed numbering, so that it now increments both in shell and in markdown

* Added atom and vscode to config examples

* Add simple way of setting up fake remote for exercises

* Change reorder-the-history exercise to use a remote

This allows `git rebase -i` to automatically go back
to origin/master if no target tree'ish is specified.

* Change fake remote script to create bare repo

Clean up new util shell scripts to separate files

* Fixed a typo in reorder-the-history/README.md

* Tweaked markdown in configure-git katas a bit.

* Added .gitattributes to make line endings consistent.

There was a mixture of both DOS and UNIX line endings in the files. The .gitattributes
file can serve as an example.

* Added more explanatory text to basic-commits/README

* Added exercise about excluding something from .gitignore

* Introduction to github

* Added exec-flag to setup.sh script, and fixed syntax error with shebang.

* Set theme jekyll-theme-midnight

* Use makerepo function

* Added to Merge Mergesort README

Added to the task and to the relevant commands

* Added useful commands section to amend/README.

* Added to the task in reorder-the-history/README.

Also added to useful commands.

* Add clone step to README Gif

* Added useful commands and more to reset/README

Added useful commands section and a further explanation section.

* Added the task section to bad-commit/README.md

Added a detailed the task section and added to useful commands.

* Added The task to commit-on-wrong-branch/README.md

Also added Useful commands

* Added to The task in merge-conflict/README.md

Added detailed steps to The tasks and updated the Relevant commands

* Added to The task in reverted-merge/README.md

Added detail to The task and added to Useful commands.

* Added The task in save-my-commit/README.md

Updated the README to be more similar to others.
Made The task slightly clearer and added some hints (via googling)

* Added to the task detached-head/README.

* Made The task more standard and added some detail.
* Added useful commands.

* Changed "git" to "Git" in detached-head/README

* Update README.md

Fix a typo

* Added kata about git tags.

* Improved squashing/README.md

* Made section names more consistent with other READMEs
* How to clean up the \n's wasn't clear so made it it own step and
added to Useful commands
* Added Further information on how to write Git commit messages
* Left in question on git rev-parse. Why this is useful should be made
clearer or the command deleted.

* Removed reference to 'git rev-pars'

* Minor improvements to submodules/README.md

* Made more standard.
* Added some explanatory text about why steps are being done.
* Replaced reference to `git submodule status` with
  `git submodule foreach 'git status'`, because it isn't obvious what the
  output of `git submodule status` means
* Not sure why we are making a second clone so put a TBD.

* Fix link in squashing-README

* Simplify `git lol` alias

`--oneline` is is a shorthand for `--pretty=oneline --abbrev-commit`, see git-log(1)

* Added kata for .gitattributes

* Mention `less` in SHELL-BASICS.md

Helpful alternative to `cat` for long files.

* Word ordering

* Add missing shebang in squashing/setup.sh

`setup.sh` should be executable according to the instructions given in README.md

* fix: wording

* Reordered katas on Overiew and added missing ones

Also grouped into sections in a suggested order.

* Added pointer to Overview also as Learning Path

With change to Overview file, it also contains a learning path.

* Use explicit numbering

* Expand  on  submodules kata

* Fix three typos

* Fix typos in submodule README

* Add kata Rebase Interactive with autosquash

* Clean up unused trainer-notes.md

* Update README.md

`git show <commit id>` was very helpful to me when I did this kata & and later on the job

* Updating git cheatsheet

* clarified pull-request comments

* correction to wrong description of 'git reset'

* clearing the description to be precise

* changed how shell script could be sourced in katas

* Set local git user name and email after initializing exercise repo (to distinguish commits).

* updating a email address to look like one.

* chaning email address to suggested

* helper functions to set and unset local user for training bot commits. Updated setup.sh instructions in few katas to take new effect in place.

* unset error option at the end

* advanced-rebase-interactive README: be consistent with cmdline args

Use `--interactive` as in previous step.

* configure-git README.md: mention private SSH key file

Mention files corresponding to public/private key.

* Simplify basic revert

close eficode-academy#177

* Elaborate and bugfix on rebase-exec

close eficode-academy#187

* use local remote for prepush kata

* Elaborate save my commit

* Small typos in ignore kata README

* Add master based workflow kata

* Fix wording in new exercise description

* Add fake author in master-based-workflow exercise

To easily distinguish own commits from the "virtual" collaborator's
ones.

* Fleshed out section one of config-git.md

* Fixed language and content for config-git

* Consistently use dashes in utils function names

Fix eficode-academy#248

* Add +x rights to pre-push setup.sh

* [Master Workflow] Fix Autor typo

* Consistently write 'Git' if talking about the tool

- Use 'Git' for the tool name
- Use 'git' as the command

* First try to rework "Configure Git" kata

- Start with installation, mention to open Git Bash one time for
  further cfg. steps
- Sub-chapter about SSH authentication

* Prevent weird errors when running setup.sh using e.g. bash setup-sh instead of source setup.sh

* Fix setup scripts of `submodule` kata

- Use parts of the infrastructure in `../utils/`
- Sourcing (`. setup.sh`) or executing (`./setup.sh`) the script now both works
- Don't try to be smarter than the average setup.sh script if it doesn't work anyway...

* Create GitHub actions CI pipeline for running test scripts (eficode-academy#265)

* Create CI pipeline running test scripts

* Fix CI definition

* Add execute access to test.sh

* Fix CI definition

* Make test.ps1 go through all exercises

* Add git user for submodules kata

* Add git user for submodules kata

* Fix setup.ps1 for submodules kata

* Add MacOS to GitHub actions jobs

* Create setup and verify scripts for bisect kata

Resolves: eficode-academy#164

* Create setup script for merge-driver kata

Resolves: eficode-academy#164

* Add file ending new lines

* Add setup.ps1 for git-attributes kata

Related issue: eficode-academy#261

* Add setup.ps1 for git-tag kata

Related issue: eficode-academy#261

* Add setup.ps1 for master-based-workflow kata

Related issue: eficode-academy#261

* Update README.md for git-attributes and git-tag

Add `setup.ps1` to the README.md files.

* Add setup.ps1 for pre-push kata

* Add setup.ps1 and verify.ps1 for rebase-exec kata

Related issue: eficode-academy#261

* Update README.md for bisect and merge-driver

* Gracefully fail when removing exercises folder

If for whatever reason the `exercises` folder cannot be removed the
`setup.ps1` script did not stop but continue running potentionally
spilling a lot of error messages.
With this change the failing deletion will stop the setup script.

Resolves: eficode-academy#243

* Further improve error handling in setup.ps1

Resolves: eficode-academy#243

* FIX problem that kills shell if not bash (eficode-academy#268)

Co-authored-by: Jan Krag <jankrag@gmail.com>

* adding Dockerfile with zsh for regression test

* Complete zsh test

* Fix errors in actions CI file

* added explanatory text to ffmerge README

* Update README.md

* Disable GPG signing of commits locally during setup

As signing might be enabled globally, commits from setup scripts local user
should happen without signing.

* Add VS Code as a suggested editor

* Create change author kata

With this kata you can practice what does it take to change the authors
of already committed and pushed commits.
The idea sprang from a personal experience.

* Fix PR review findings

* Add commands that show contents of commits to better illustrate amending via adding a new file.

* Add an explanation for commands to run with amend.

* Final proposal for subtree git-katas

Co-authored-by: Mads Jensen <mads.jensen@eficode.com>

* Add publish workflow

This is a precursor to our upcoming release pipeline, where the katas are made accessible without cloning them down, causing the dreaded nested git repo confusion.

* Change archive publising to a GH Release

* Fix indentation issue in publish.yml

* Fix tag in release asset name

Co-authored-by: Katrin Leinweber <Katrin.Leinweber@tib.eu>
Co-authored-by: Johan Sigfred Abildskov <randomsort@gmail.com>
Co-authored-by: Jan Krag <jankrag@gmail.com>
Co-authored-by: Frank Theile <frank.theile@web.de>
Co-authored-by: Adam Matan <adam@matan.name>
Co-authored-by: Thanh-Nhon NGUYEN <ntnhon.cs@gmail.com>
Co-authored-by: Sofus Albertsen <soa@praqma.com>
Co-authored-by: Adam Matan <adamatan@users.noreply.github.com>
Co-authored-by: kvartborg <hello@kvartborg.net>
Co-authored-by: Victor Gram Thomsen <victor_gram@ymail.com>
Co-authored-by: Jan Krag <jak@praqma.net>
Co-authored-by: Mads Jensen <maj@praqma.net>
Co-authored-by: Brent Clark <clark@sedsystems.ca>
Co-authored-by: Natasha2001 <natashasee.2001@gmail.com>
Co-authored-by: Alex Blanc <alexandre_blanc@yahoo.fr>
Co-authored-by: Frank Theile <ftheile@grundfos.com>
Co-authored-by: Fuchen Shi <44103628+shifuchen98@users.noreply.github.com>
Co-authored-by: Michael Ingeman-Nielsen <min@praqma.net>
Co-authored-by: Sudheer Kumar Chiluveri <Sudheer.Chiluveri@gmail.com>
Co-authored-by: Sofus Albertsen <sofusalbertsen@users.noreply.github.com>
Co-authored-by: git-katas trainer bot <git-katas@example.com>
Co-authored-by: Thierry Lacour <thi@praqma.net>
Co-authored-by: Niels Kristian Jensen @ MAN <nielsk.jensen@man-es.com>
Co-authored-by: bothzoli <bothzoli@gmail.com>
Co-authored-by: Christoffer Nissen <christoffer.nissen@eficode.com>
Co-authored-by: Joachim Bülow <43139346+joachimbulow@users.noreply.github.com>
Co-authored-by: Dan Grøndahl Glavind <dan.glavind@eficode.com>
Co-authored-by: Thierry Lacour <thierry.lacour@eficode.com>
Co-authored-by: EfiGaja <gaja.kochaniewicz@eficode.com>
Co-authored-by: Claus Schneider (Praqma) <cls@praqma.net>
Co-authored-by: Mads Jensen <mads.jensen@eficode.com>
CristianStanciu pushed a commit to CristianStanciu/git-katas that referenced this issue Jun 2, 2022
@bothzoli @RandomSort
Gracefully fail when removing exercises folder
33249c1 
If for whatever reason the `exercises` folder cannot be removed the
`setup.ps1` script did not stop but continue running potentionally
spilling a lot of error messages.
With this change the failing deletion will stop the setup script.

Resolves: eficode-academy#243
CristianStanciu pushed a commit to CristianStanciu/git-katas that referenced this issue Jun 2, 2022
@bothzoli @RandomSort
Further improve error handling in setup.ps1
5636667 
Resolves: eficode-academy#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@RandomSort