Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully fail when removing exercises folder in PowerShell setup scripts #266

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Gracefully fail when removing exercises folder in PowerShell setup scripts #266

merged 2 commits into from
Jul 1, 2020

Conversation

bothzoli
Copy link
Contributor

If for whatever reason the exercises folder cannot be removed the setup.ps1 script did not stop but continue running potentionally spilling a lot of error messages.
With this change the failing deletion will stop the setup script.

Resolves: #243

@RandomSort
Copy link
Contributor

HI, Thank you for your contribution.
I will wait for your go ahead to merge this pull request - perhaps you want to change the author on your commits, such that it is you, and not git-katas trainer bot that is credited :D

Cheers

RandomSort
RandomSort suggested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@RandomSort RandomSort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing the author of the commits to your own :)

@bothzoli
Gracefully fail when removing exercises folder
7444bd2 
If for whatever reason the `exercises` folder cannot be removed the
`setup.ps1` script did not stop but continue running potentionally
spilling a lot of error messages.
With this change the failing deletion will stop the setup script.

Resolves: #243
@bothzoli
Further improve error handling in setup.ps1
f9e59b9 
Resolves: #243
@bothzoli
Copy link
Contributor Author

bothzoli commented Jul 1, 2020 •
edited
Loading

lol, i didn't even notice 😂
should've done it with my other PRs as well, but doesn't matter.
at least git-katas trainer bot also gets some credit 😊

maybe i'll even create a kata from this, i had to look it up how to do it

@bothzoli bothzoli requested a review from RandomSort July 1, 2020 16:04
@RandomSort RandomSort merged commit 98d531e into eficode-academy:master Jul 1, 2020
@RandomSort
Copy link
Contributor

Thanks!
Perhaps it could be an addition to the amend kata ? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomSort RandomSort RandomSort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When powershell scripts fail they should abort execution
2 participants
@bothzoli @RandomSort