Skip to content

Commit

Permalink
Merge pull request kata-containers#720 from jcvenegas/fix-716
Browse files Browse the repository at this point in the history
Revert: client.go: HybridVSockDialer: Change Read EOT to recv peek
  • Loading branch information
jcvenegas authored Jan 27, 2020
2 parents 7c2d8ab + 660e61f commit 686708d
Showing 1 changed file with 6 additions and 21 deletions.
27 changes: 6 additions & 21 deletions protocols/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,16 @@ package client
import (
"context"
"fmt"
"io"
"net"
"net/url"
"strconv"
"strings"
"syscall"
"time"

"github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc"
"github.com/hashicorp/yamux"
"github.com/mdlayher/vsock"
opentracing "github.com/opentracing/opentracing-go"
"golang.org/x/sys/unix"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
grpcStatus "google.golang.org/grpc/status"
Expand Down Expand Up @@ -410,24 +407,12 @@ func HybridVSockDialer(sock string, timeout time.Duration) (net.Conn, error) {
return nil, err
}

// Receive the packet from the connection without removing it from
// the receive queue (MSG_PEEK), ensuring the connection is usable.
if uc, ok := conn.(*net.UnixConn); ok {
file, err := uc.File()
if err != nil {
conn.Close()
return nil, err
}
eot := make([]byte, 1)
n, _, err := unix.Recvfrom(int(file.Fd()), eot, syscall.MSG_PEEK)
file.Close()
if err != nil || n == 0 {
conn.Close()
if err == nil {
err = io.EOF
}
return nil, err
}
// Read EOT (End of transmission) byte
eot := make([]byte, 32)
if _, err = conn.Read(eot); err != nil {
// Just close the connection, gRPC will dial again
// without errors
conn.Close()
}

return conn, nil
Expand Down

0 comments on commit 686708d

Please sign in to comment.