This repository has been archived by the owner on May 12, 2021. It is now read-only.
cli: add guest hook path option #720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PSS Measurement: Memory inside container: |
|
Build succeeded (third-party-check pipeline).
|
|
Added Once the dependent branch is merged, we can remove the label ;) |
Blocked on (kata-containers/agent#365), will need to revendor.
eguzman3
force-pushed
the
guest-hooks
branch
from
60e9fe4 to
895fa27
Compare
|
Hey @eguzman3 - it seems like this PR has more than just adding the guest hooks - can you split into multiple well described commits, and perhaps as seperate PRs? Please let me know if I'm mistaken... |
|
And, please disregard my comment -- I see that I was in the weeds looking at the vendor code. Thanks! |
|
@egernst @eguzman3 once kata-containers/agent#365 lands, it's still cleaner if you split the vendoring code in its own commit ;) |
|
Still blocked on kata-containers/agent#365. |
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 17, 2018
We need kata-containers/agent#393 in order for kata-containers#720 to be carried forward Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 17, 2018
Fixes: kata-containers#720 Co-authored-by: Edward Guzman <eguzman@nvidia.com> Co-authored-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 17, 2018
We need kata-containers/agent#393 in order for kata-containers#720 to be carried forward Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 17, 2018
Fixes: kata-containers#720 Co-authored-by: Edward Guzman <eguzman@nvidia.com> Co-authored-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 17, 2018
Fixes: kata-containers#720 Co-authored-by: Edward Guzman <eguzman@nvidia.com> Co-authored-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 18, 2018
We need kata-containers/agent#393 in order for kata-containers#720 to be carried forward github.com/kata-containers/agent: 3a678a9 agent: Fix the issue of stdout hang on builtin proxy d12910e agent: judge whether /sys/devices/system/memory/block_size_bytes exist. 980023e agent: add support for guest-hooks e03f7d7 memory: Fix update memory path. a396a23 grpc: Add seccomp status to guest details 7b71c10 grpc: Add agent details to guest details call 4fefa1a release: Kata Containers 1.3.0 a628496 device: rescan pci bus before waiting for new devices 1310f3d device: fix redefined notify channel 4163b8b uevent:Revert "device: check for existing device PCI path before waiting" 54f77cf agent: support agent as init process in rootfs images ef62167 uevent: Add logs for uevents fc907f6 agent: fix the issue of missing close process terminal d71dd02 vendor: bump runtime-spec version 28a5ab2 release: Kata Containers 1.3.0-rc1 2b89a0a uevent: fix crash on read errors 9cf56c0 agent: auto-online hotplug memory 33aea09 CI: Add "make proto" 00a5588 Makefile: Conditionally build agent with tag seccomp 7caf1c8 device: check for existing device PCI path before waiting 3441244 device: do not close notify channel when wait timeout github.com/opencontainers/runtime-spec: 5d9aa69 config-linux: Add Intel RDT/MBA Linux support 6f5fcd4 Support for network namespace in windows 06cf899 config-linux: add Intel RDT CLOS name sharing support f3be7d2 config: clarify source mount 65fac2b Fix camelCasing on idType to align with other Windows spec conventions da8adc9 incorporating edits from JTerry's feedback c182ebc meeting: Bump July meeting from the 4th to the 11th e01b694 config: Add Windows Devices to Schema 81d81f3 docs: Added kata-runtime to implementations b0700ad Add gVisor to the implementations list 9e459a6 .travis.yml: Get schema dependencies in before_install 692abcb .travis: Bump minimum Go version to 1.9 fd39559 config: Clarify execution environment for hooks cd9892d config-linux: Drop console(4) reference e662e5c Linux devices: uid/gid relative to container 74b670e config: Add VM-based container configuration section cd39042 uidMappings: change order of fields for clarity 2e241f7 specs-go/config: Define RDMA cgroup 9df387e schema/Makefile: fix test de688f2 config: Fix Linux mount options links ef008dd glossary: Bump JSON spec to RFC 8259 4e5a137 schema: Completely drop our JSON Schema 'id' properties 70ba4e6 meeting: Bump January meeting from the 3rd to the 10th 8558116 schema: add allowed values for defaultAction 5d9bbad config: Dedent root paragraphs, since they aren't a list entry e566cf6 version: put master back to -dev 966a58d fix the link to hook Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 18, 2018
Fixes: kata-containers#720 Co-authored-by: Edward Guzman <eguzman@nvidia.com> Co-authored-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
|
@eguzman3 ping (From your weekly Kata herder). It is still blocked? |
|
I think we can drop this one cause there is a new version #834 |
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 24, 2018
Add support for specifying an optional drop-in path for guest OCI hooks. This is the runtime side for leveraging the agent change introduced in kata-containers/agent@980023e Fixes: kata-containers#720 Co-authored-by: Edward Guzman <eguzman@nvidia.com> Co-authored-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
|
Closing this since it's replaced. |
flx42
added a commit
to flx42/runtime
that referenced
this pull request
Oct 29, 2018
Add support for specifying an optional drop-in path for guest OCI hooks. This is the runtime side for leveraging the agent change introduced in kata-containers/agent@980023e Fixes: kata-containers#720 Co-authored-by: Edward Guzman <eguzman@nvidia.com> Co-authored-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Nov 22, 2018
Add support for specifying an optional drop-in path for guest OCI hooks. This is the runtime side for leveraging the agent change introduced in kata-containers/agent@980023e Fixes: kata-containers#720 Co-authored-by: Edward Guzman <eguzman@nvidia.com> Co-authored-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
Revert: client.go: HybridVSockDialer: Change Read EOT to recv peek
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on (kata-containers/agent#365), will need to revendor.