feat: [BREAKING_CHANGE] use egg-core #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
后来是没开 travis？ |
|
deps eggjs/core#6 |
|
我先发个 0.1.0-beta.1 测试 |
|
@fengmk2 这个没有 ci 怎么跑？ |
|
|
private repo 需要收费。。。 |
|
恩，我现在本地跑的 |
|
可以重新跑了 |
|
|
加了个 circleci https://circleci.com/gh/eggjs/egg/2 |
| @@ -53,7 +53,7 @@ module.exports = { | |||
| * @since 1.0.0 | |||
| */ | |||
| i18n: { | |||
| enable: false, | |||
| enable: true, | |||
|
@fengmk2 原来 examples 的用例好像就跑不过 |
|
view 层好像有些用例 skip 了 @atian25 |
| * @member {Service} Egg#Service | ||
| * @since 1.0.0 | ||
| */ | ||
| exports.Service = require('./lib/core/base_service'); |
|
@popomore view 的测试, 这里是不是不用引入 egg-view-nunjucks 了? 直接在 fixtures 里面实现一个简单的 view 来测试 render 和 renderString. 等你这个 PR ok 了我再补下 |
| @@ -24,7 +25,6 @@ class Application extends EggApplication { | |||
| options = options || {}; | |||
| options.type = 'application'; | |||
| super(options); | |||
| this.loader.loadApplication(); | |||
|
@atian25 恩，是的 |
| @@ -5,7 +5,7 @@ module.exports = function* () { | |||
| bar1: yield this.service.foo.bar.get('bar1name'), | |||
| bar2: yield this.service.foo.subdir.bar.get('bar2name'), | |||
| 'foo.subdir2.sub2': yield this.service.foo.subdir2.sub2.get('bar3name'), | |||
| subdir11bar: !!this.service.foo.subdir1, | |||
| subdir11bar: yield this.service.foo.subdir1.subdir11.bar.get(), | |||
|
这个还差啥? |
|
差苏千 review |
popomore
changed the title
|
这个再看看，没问题先把这个合了，不然越来越大 |
|
觉得可以先合了 |
|
合一把 |
|
合了. squash 后就只有一条 commit 了, 后面尽量小 commit 好了, 不然好难写 squash message |
|
恩，一个 PR 就一个 |
|
先发个 |
|
好, 你发吧 |
|
elrrrrrrr
pushed a commit
to elrrrrrrr/egg
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
loader, Application
Description of change
直接依赖 egg-core，egg-core 有一些不兼容更新
插件