Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [BREAKING_CHANGE] use loader.getLoadUnits from egg-core #6

Merged
merged 2 commits into from
Aug 16, 2016

Conversation

popomore
Copy link
Member

@popomore popomore commented Aug 16, 2016

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

None

Description of change

egg-core 重构后,使用 loader 新的 API getLoadUnits

@mention-bot
Copy link

@popomore, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dead-horse, @atian25 and @fengmk2 to be potential reviewers

@popomore
Copy link
Member Author

这个要发大版本?都 1.0 了

@atian25
Copy link
Member

atian25 commented Aug 16, 2016

感觉用 setTimeout 这里时间不精确,用例好像有点不稳定,有时会多一个少一个。

+1

@fengmk2
Copy link
Member

fengmk2 commented Aug 16, 2016

发 patch 就好

@fengmk2 fengmk2 merged commit 2b01539 into master Aug 16, 2016
@fengmk2 fengmk2 deleted the use-new-egg branch August 16, 2016 14:59
@fengmk2
Copy link
Member

fengmk2 commented Aug 16, 2016

1.1.1

2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants