Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated stories #134

Merged
merged 1 commit into from
Oct 9, 2024
Merged

updated stories #134

merged 1 commit into from
Oct 9, 2024

Conversation

Swathi-eGov
Copy link

No description provided.

@jagankumar-egov jagankumar-egov merged commit d867276 into develop Oct 9, 2024
1 check passed
Copy link

coderabbitai bot commented Oct 9, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several enhancements across multiple components in the react/ui-components library. Key changes include the addition of prop type validations for the NestedTable, SlideOverMenu, and TableCell components, ensuring that the correct data types are passed. Additionally, several components had their prop names corrected for consistency, and various story files were reorganized to reflect a new hierarchy. The overall goal of these changes is to improve the robustness and clarity of the component library.

Changes

File Path Change Summary
src/atoms/NestedTable.js Added prop types: nestedData, toggleRowExpansion, rowIndex.
src/atoms/SlideOverMenu.js Removed onClose, added addClose, closedContents, closedSections, closedHeader, closedFooter, transitionDuration.
src/atoms/TableCell.js Added prop types: updateTableData, tableData, rowIndex, cellIndex.
src/atoms/TextBlock.js Corrected prop names from ClasName to ClassName.
src/atoms/TextInput.js Adjusted input class name handling; no public entity changes.
src/atoms/stories/Animation.stories.js Updated export title to "Foundations/Animations".
src/atoms/stories/ColorLibrary.stories.js Updated export title to "Foundations/ColorLibrary"; added capitalizedColorName.
src/atoms/stories/SVG.stories.js Updated title to "Foundations/Iconography"; added a new style object.
src/atoms/stories/Spacers.stories.js Updated export title to "Foundations/Spacers".
src/atoms/stories/TextBlock.stories.js Corrected property names in Default.args from ClasName to ClassName.
src/molecules/FilterCard.js Added a check in handleOverlayClick to ensure onOverlayClick is defined.
src/molecules/stories/CardVariantPrimaryCard.stories.js Corrected property names for TextBlock from ClasName to ClassName.
src/molecules/stories/CardVariantSecondaryCard.stories.js Corrected property names for TextBlock from ClasName to ClassName.
src/molecules/stories/Example.stories.js Corrected property names for TextBlock from ClasName to ClassName.
src/molecules/stories/FilterCard.stories.js Renamed exported constants from Veritcal to Vertical.

Possibly related PRs

  • React component changes #126: Changes in Accordion.js involve modifications to props, possibly relating to similar prop validation patterns as in NestedTable.
  • Component enhancements react #129: The Chip.js component introduces a new prop for controlling the visibility of the close icon, aligning with enhancements made in NestedTable.
  • Table molecule #131: The introduction of the TableMolecule component includes prop definitions and validation that may relate to NestedTable's prop types.

Suggested reviewers

  • jagankumar-egov: Suggested as a reviewer for this pull request.

Poem

🐰 In the garden of code, we hop with delight,
With props all in order, our components shine bright.
Class names corrected, validation in place,
A library of wonders, we joyfully embrace!
So let’s raise our carrots, for changes so grand,
A robust little world, built by our hand! 🌼🥕


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants