added shpicon in customsvgs #136
Conversation
WalkthroughThe changes in this pull request involve updating the linked CSS stylesheet version from Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
react/ui-components/src/atoms/CustomSVG.js (1)
3-13: LGTM with suggestions for improvementThe
ShpIconcomponent is implemented correctly and follows React best practices. However, consider the following improvements:
- Extract the base64-encoded image data to a separate file or use an external image source for better maintainability.
- Add PropTypes for type checking the
classNameprop.Example of adding PropTypes:
import PropTypes from 'prop-types'; // ... component implementation ... ShpIcon.propTypes = { className: PropTypes.string };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (6)
react/css/package.jsonis excluded by!**/*.jsonreact/example/package.jsonis excluded by!**/*.jsonreact/modules/core/package.jsonis excluded by!**/*.jsonreact/modules/sample/package.jsonis excluded by!**/*.jsonreact/package.jsonis excluded by!**/*.jsonreact/ui-components/package.jsonis excluded by!**/*.json
📒 Files selected for processing (5)
- react/example/public/index.html (1 hunks)
- react/ui-components/.storybook/preview-head.html (1 hunks)
- react/ui-components/public/index.html (1 hunks)
- react/ui-components/src/atoms/CustomSVG.js (2 hunks)
- react/ui-components/src/molecules/stories/BottomSheet.stories.js (1 hunks)
✅ Files skipped from review due to trivial changes (2)
- react/ui-components/.storybook/preview-head.html
- react/ui-components/public/index.html
🧰 Additional context used
🔇 Additional comments (6)
react/example/public/index.html (1)
12-12: CSS version update looks good, but verify compatibility.The update of the CSS version from
0.0.2-beta.37to0.0.2-beta.38seems correct. This change likely introduces new styles or fixes for the DIGIT UI components.To ensure this change doesn't introduce any breaking changes or inconsistencies, please:
- Verify that this version update is consistent across all files in the project.
- Check the changelog for
@egovernments/digit-ui-components-cssto understand what changes are introduced in this version.- Test the application thoroughly to ensure no visual regressions or unexpected behavior.
Run the following script to check for consistency across the project:
This script will help identify any inconsistencies in the CSS version across the project.
✅ Verification successful
CSS version update is consistent across the project.
All instances of
@egovernments/digit-ui-components-csshave been successfully updated to version0.0.2-beta.38, ensuring consistency throughout the project.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for consistency of CSS version across HTML files # Test: Search for occurrences of digit-ui-components-css version echo "Searching for digit-ui-components-css versions:" rg --type html "digit-ui-components-css@[0-9]+\.[0-9]+\.[0-9]+-beta\.[0-9]+" echo "Verifying consistency:" rg --type html "digit-ui-components-css@0\.0\.2-beta\.38" | wc -lLength of output: 593
react/ui-components/src/molecules/stories/BottomSheet.stories.js (4)
1-27: LGTM: Imports and Storybook configuration are well-structured.The imports are appropriate for the BottomSheet component stories. The Storybook configuration in the default export is comprehensive, covering all necessary props with proper control types.
29-37: LGTM: Template and commonArgs are well-defined.The Template function and commonArgs object follow best practices for Storybook stories. This setup promotes consistency across stories and reduces code duplication.
61-94: LGTM: Basic state stories are well-structured and comprehensive.The stories for different BottomSheet states (Closed, Fixed, Quarter, Intermediate, and Full) are implemented consistently and cover all possible initial states. The use of
Template.bind({})and spreadingcommonArgspromotes code reuse and maintainability.
96-139: LGTM: Stories with actions are comprehensive and consistent.The stories for BottomSheet states with actions enabled are well-implemented. They maintain consistency with the basic state stories while adding the
enableActionsprop andactionsarray. This set of stories ensures good coverage of the component's functionality with actions.react/ui-components/src/atoms/CustomSVG.js (1)
3564-3565: LGTM: Correct export of the new componentThe
ShpIconcomponent is correctly added to the existing export object, maintaining consistency with other components in the file.
|
add svgs only into svg library |
No description provided.