Skip to content

Commit

Permalink
Silicon thresholds (#890)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
Moving silicon detector thresholds documented in
https://docs.google.com/spreadsheets/d/1s8oXj36SqIh7TJeHFH89gQ_ayU1_SVEpWQNkx6sETKs/edit#gid=238482234
from npsim into digitization.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
Yes.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
  • Loading branch information
3 people authored Sep 6, 2023
1 parent 7124de3 commit 08b1ac1
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/detectors/B0TRK/B0TRK.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void InitPlugin(JApplication *app) {
{"B0TrackerHits"},
{"B0TrackerRawHits"},
{
.threshold = 0 * dd4hep::keV,
.threshold = 1.0 * dd4hep::keV,
.timeResolution = 8,
},
app
Expand Down
2 changes: 1 addition & 1 deletion src/detectors/BTOF/BTOF.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void InitPlugin(JApplication *app) {
{"TOFBarrelHits"},
{"TOFBarrelDigiHit"},
{
.threshold = 0 * dd4hep::keV,
.threshold = 0.5 * dd4hep::keV,
.timeResolution = 0.025, // [ns]
},
app
Expand Down
4 changes: 3 additions & 1 deletion src/detectors/BTRK/BTRK.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ void InitPlugin(JApplication *app) {
"SiBarrelRawHits",
{"SiBarrelHits"},
{"SiBarrelRawHits"},
{}, // default config
{
.threshold = 0.65 * dd4hep::keV,
},
app
));

Expand Down
4 changes: 3 additions & 1 deletion src/detectors/BVTX/BVTX.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ void InitPlugin(JApplication *app) {
"BarrelVertexRawHits",
{"VertexBarrelHits"},
{"BarrelVertexRawHits"},
{}, // default config
{
.threshold = 0.65 * dd4hep::keV,
},
app
));

Expand Down
4 changes: 3 additions & 1 deletion src/detectors/ECGEM/ECGEM.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ void InitPlugin(JApplication *app) {
"GEMTrackerEndcapHits3"
},
{"GEMRawHit"},
{}, // default config
{
.threshold = 0.25 * dd4hep::keV,
},
app
));

Expand Down
2 changes: 1 addition & 1 deletion src/detectors/ECTOF/ECTOF.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void InitPlugin(JApplication *app) {
{"TOFEndcapHits"},
{"TOFEndcapRawHits"},
{
.threshold = 0 * dd4hep::keV,
.threshold = 0.5 * dd4hep::keV,
.timeResolution = 0.025,
},
app
Expand Down
4 changes: 3 additions & 1 deletion src/detectors/ECTRK/ECTRK.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ void InitPlugin(JApplication *app) {
"EndcapTrackerDigiHit",
{"TrackerEndcapHits"},
{"EndcapTrackerDigiHit"},
{}, // default config
{
.threshold = 0.65 * dd4hep::keV,
},
app
));

Expand Down

0 comments on commit 08b1ac1

Please sign in to comment.