-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silicon thresholds #890
Merged
Silicon thresholds #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: tracking
Relates to tracking reconstruction
topic: PID
Relates to PID reconstruction
topic: far-forward
Far forward reconstruction
topic: barrel
topic: forward
labels
Sep 1, 2023
wdconinc
reviewed
Sep 1, 2023
wdconinc
requested changes
Sep 5, 2023
I deleted the two instances of made-up time resolution. |
Where? |
wdconinc
reviewed
Sep 5, 2023
wdconinc
reviewed
Sep 5, 2023
Good call. |
wdconinc
reviewed
Sep 6, 2023
wdconinc
approved these changes
Sep 6, 2023
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: barrel
topic: far-forward
Far forward reconstruction
topic: forward
topic: PID
Relates to PID reconstruction
topic: tracking
Relates to tracking reconstruction
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Moving silicon detector thresholds documented in https://docs.google.com/spreadsheets/d/1s8oXj36SqIh7TJeHFH89gQ_ayU1_SVEpWQNkx6sETKs/edit#gid=238482234
from npsim into digitization.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes.