Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silicon thresholds #890

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Silicon thresholds #890

merged 5 commits into from
Sep 6, 2023

Conversation

kkauder
Copy link
Contributor

@kkauder kkauder commented Sep 1, 2023

Briefly, what does this PR introduce?

Moving silicon detector thresholds documented in https://docs.google.com/spreadsheets/d/1s8oXj36SqIh7TJeHFH89gQ_ayU1_SVEpWQNkx6sETKs/edit#gid=238482234
from npsim into digitization.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Yes.

@github-actions github-actions bot added topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: far-forward Far forward reconstruction topic: barrel topic: forward labels Sep 1, 2023
@kkauder kkauder requested review from sly2j and veprbl September 1, 2023 21:22
src/detectors/BTRK/BTRK.cc Outdated Show resolved Hide resolved
src/detectors/BVTX/BVTX.cc Outdated Show resolved Hide resolved
src/detectors/ECGEM/ECGEM.cc Outdated Show resolved Hide resolved
src/detectors/ECTRK/ECTRK.cc Outdated Show resolved Hide resolved
src/detectors/BTRK/BTRK.cc Outdated Show resolved Hide resolved
@kkauder
Copy link
Contributor Author

kkauder commented Sep 5, 2023

I deleted the two instances of made-up time resolution.

@wdconinc
Copy link
Contributor

wdconinc commented Sep 5, 2023

I deleted the two instances of made-up time resolution.

Where?

@kkauder
Copy link
Contributor Author

kkauder commented Sep 5, 2023

b0168d4

src/detectors/BVTX/BVTX.cc Outdated Show resolved Hide resolved
@kkauder
Copy link
Contributor Author

kkauder commented Sep 5, 2023

Good call.

src/detectors/BVTX/BVTX.cc Outdated Show resolved Hide resolved
src/detectors/ECTRK/ECTRK.cc Outdated Show resolved Hide resolved
@wdconinc wdconinc added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 08b1ac1 Sep 6, 2023
53 checks passed
@wdconinc wdconinc deleted the koljadev branch September 6, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel topic: far-forward Far forward reconstruction topic: forward topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants