Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext-header): Implement validate method #8

Merged
merged 10 commits into from
Jun 27, 2023

Conversation

zvolin
Copy link
Member

@zvolin zvolin commented Jun 26, 2023

No description provided.

@zvolin zvolin requested a review from oblique June 26, 2023 12:59
Copy link
Member

@oblique oblique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have few comments.

types/src/block.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
types/src/validator_set.rs Outdated Show resolved Hide resolved
types/src/validator_set.rs Outdated Show resolved Hide resolved
types/src/validate.rs Outdated Show resolved Hide resolved
types/src/block.rs Outdated Show resolved Hide resolved
types/src/block.rs Outdated Show resolved Hide resolved
types/src/block.rs Outdated Show resolved Hide resolved
types/src/block.rs Outdated Show resolved Hide resolved
types/src/block.rs Outdated Show resolved Hide resolved
Copy link
Member

@oblique oblique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oblique oblique merged commit 82bd414 into eigerco:main Jun 27, 2023
@zvolin zvolin deleted the feat/ext-headers-validate branch June 28, 2023 11:26
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
@zvolin zvolin mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants