Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext-header): Implement validate method #8

Merged
merged 10 commits into from
Jun 27, 2023
Merged

feat(ext-header): Implement validate method #8

merged 10 commits into from
Jun 27, 2023

Commits on Jun 26, 2023

  1. feat(ext-header): Implement validate method

    @zvolin
    zvolin committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    997018c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Yiannis Marangos <psyberbits@gmail.com>
    @zvolin @oblique
    zvolin and oblique authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    3464780 View commit details
    Browse the repository at this point in the history

  2. correct acronym casing in error variant

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a3290fc View commit details
    Browse the repository at this point in the history

  3. correct leftover acronym casing in tests

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c67b421 View commit details
    Browse the repository at this point in the history

  4. replace IsZero trait with standalone function

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d1bbb72 View commit details
    Browse the repository at this point in the history

  5. more meaningful name for iteration index

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    3f22736 View commit details
    Browse the repository at this point in the history

  6. error instead of panic on invalid signature index

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    103fbbe View commit details
    Browse the repository at this point in the history

  7. introduce a constant for the height of genesis block

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d375041 View commit details
    Browse the repository at this point in the history

  8. move is_zero to the end of module

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    391f97d View commit details
    Browse the repository at this point in the history

  9. remove pub from genesis heigth constant

    @zvolin
    zvolin committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    bba5b13 View commit details
    Browse the repository at this point in the history