Fix inline background image url rewriting #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsmason
approved these changes
Dec 17, 2024
|
This tests perfectly for me. At the moment we are asking Thumbor to return an optimised image at the original dims. Do you think we should put an upper limit on the dims of the optimised image (in case CMS users upload massive originals), or shall we trust that the website admin have already applied sensible upper limits on uploads? |
edjeavons
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure any inline background image styles get rewritten to thumbor urls e.g. the cover block has a setting to fix the background position which turns it into an inline style rather than an image element