Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jetty version number to 9.4.12 #8

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

bbpennel
Copy link
Contributor

Jetty 9.4.x versions prior to 9.4.8 are subject to an startup error if any dependencies of a war file being deployed contain module-info.class files from Java 9, whether or not the project is using java 9. Information about this issue can be found here:

https://stackoverflow.com/questions/45311295/error-scanning-entry-module-info-class-when-starting-jetty-server

jetty/jetty.project#1692

Here is an example of the exception:

[main] INFO org.eclipse.jetty.server.Server - jetty-9.4.0.v20161208
[main] INFO org.eclipse.jetty.annotations.AnnotationConfiguration - Scanning elapsed time=4857ms
[main] WARN org.eclipse.jetty.webapp.WebAppContext - Failed startup of context o.s.j.JettyConsoleWebappContext@643b1d11{/,file:///private/var/folders/kh/mfmlr7jn1hxcn151fvnhkpg80000gp/T/fcrepo-webapp-5.0.0-SNAPSHOT-jetty-console.jar_8080/webapp/,UNAVAILABLE}{/Users/danny/code/fcrepo4/fcrepo-webapp/target/fcrepo-webapp-5.0.0-SNAPSHOT-jetty-console.jar}
java.lang.RuntimeException: Error scanning entry module-info.class from jar file:///private/var/folders/kh/mfmlr7jn1hxcn151fvnhkpg80000gp/T/fcrepo-webapp-5.0.0-SNAPSHOT-jetty-console.jar_8080/webapp/WEB-INF/lib/asm-all-repackaged-2.5.0-b32.jar
	at org.eclipse.jetty.annotations.AnnotationParser.parseJar(AnnotationParser.java:891)
	at org.eclipse.jetty.annotations.AnnotationParser.parse(AnnotationParser.java:837)
	at org.eclipse.jetty.annotations.AnnotationConfiguration$ParserTask.call(AnnotationConfiguration.java:159)
	at org.eclipse.jetty.annotations.AnnotationConfiguration$1.run(AnnotationConfiguration.java:464)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:672)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:590)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalArgumentException
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.objectweb.asm.ClassReader.<init>(Unknown Source)
	at org.eclipse.jetty.annotations.AnnotationParser.scanClass(AnnotationParser.java:959)
	at org.eclipse.jetty.annotations.AnnotationParser.parseJarEntry(AnnotationParser.java:940)
	at org.eclipse.jetty.annotations.AnnotationParser.parseJar(AnnotationParser.java:887)
	... 6 more

@awoods
Copy link

awoods commented Oct 11, 2018

We love jetty-console and it has been very helpful for the Fedora Repository community!
Until this pull-request is accepted and a new release published, we are having to work from a fork :(
https://github.com/fcrepo4-labs/jetty-console

@eirbjo
Copy link
Owner

eirbjo commented Oct 11, 2018

I'm on top of a mountain right now, so I have no chance of testing right now, but I'm going to merge now and do the QA and a release when I get back down.

Cheers,
Eirik.

@awoods
Copy link

awoods commented Oct 11, 2018

That is fantastic, @eirbjo .
Be safe.

@eirbjo eirbjo merged commit a3acdd5 into eirbjo:master Oct 12, 2018
@bbpennel bbpennel deleted the update-jetty-v branch October 12, 2018 17:16
@eirbjo
Copy link
Owner

eirbjo commented Oct 12, 2018

1.61 is released and on its way to Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants