Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation scanning should ignore module-info.class files #1692

Closed
joakime opened this issue Jul 25, 2017 · 2 comments · Fixed by scalatra/scalatra.g8#87
Closed

Annotation scanning should ignore module-info.class files #1692

joakime opened this issue Jul 25, 2017 · 2 comments · Fixed by scalatra/scalatra.g8#87
Assignees
@janbartel
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Jul 25, 2017

If a class has a JDK9 / JPMS specific feature known as module-info.class, then this class should never be scanned for annotations by Jetty's bytecode scanner.

To reproduce this bug, include the following classes in the WEB-INF/lib of a war file.

slf4j-api-1.8.0-alpha2.jar
log4j-over-slf4j-1.8.0-alpha2.jar
jcl-over-slf4j-1.8.0-alpha2.jar
@joakime joakime added Bug For general bugs on Jetty side jdk9 labels Jul 25, 2017
@joakime
Copy link
Contributor Author

joakime commented Jul 25, 2017

See: https://stackoverflow.com/questions/45311295/slf4j-error-when-starting-jetty-server

janbartel added a commit that referenced this issue Jul 26, 2017
@janbartel
Issue #1692
d9c8f89
@janbartel
Copy link
Contributor

Done for jetty-9.4.x.

joakime pushed a commit that referenced this issue Jul 29, 2017
@janbartel @joakime
Issue #1692
223c82c
joakime pushed a commit that referenced this issue Aug 8, 2017
@janbartel @joakime
Issue #1692
e81e17d
@briandealwis briandealwis mentioned this issue Aug 30, 2017
Closed
@phax phax mentioned this issue Sep 7, 2017
Closed
@joakime joakime mentioned this issue Oct 10, 2017
Closed
gregw pushed a commit that referenced this issue Oct 17, 2017
@janbartel @gregw
Issue #1692
e001823
@MichaelRoeder MichaelRoeder mentioned this issue Dec 21, 2017
Open
@joakime joakime mentioned this issue Feb 10, 2018
Closed
This was referenced Mar 7, 2018
Closed
Closed
Merged
colindean added a commit to colindean/sbt-scalatra that referenced this issue Mar 7, 2018
@colindean
Updates xsbt-web-plugin to 4.0.2 to get jetty 9.4.8
e9501cb 
Fixes scalatra#55

which was caused by jetty/jetty.project#1692

earldouglas/sbt-war#361 updated 
xsbt-web-plugin with the fix.
@colindean colindean mentioned this issue Mar 7, 2018
Merged
colindean added a commit to colindean/scalatra.g8 that referenced this issue Mar 7, 2018
@colindean
Update to sbt-scalatra 1.0.2 to get jetty 9.4.8
80e068b 
via xsbt-web-plugin 4.0.2

Root fix: jetty/jetty.project#1692

Stream: 
  earldouglas/sbt-war#361
  scalatra/sbt-scalatra#55
@colindean colindean mentioned this issue Mar 7, 2018
Merged
@gunnarmorling gunnarmorling mentioned this issue Jul 19, 2018
Closed
@bbpennel bbpennel mentioned this issue Oct 11, 2018
Merged
@briandealwis briandealwis mentioned this issue Nov 15, 2018
Closed
@johndevs johndevs mentioned this issue Dec 3, 2018
Closed
@athrane athrane mentioned this issue Jan 14, 2019
Closed
@HaloFour HaloFour mentioned this issue Oct 14, 2020
Open
@d2a-pnagel d2a-pnagel mentioned this issue Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to sbt-scalatra 1.0.2 to get jetty 9.4.8 colindean/scalatra.g8
2 participants
@joakime @janbartel