Skip to content

Commit

Permalink
Revert "host field in HTTP header is no longer limited to 31 charcters (
Browse files Browse the repository at this point in the history
nodemcu#2205)" (nodemcu#2208)

This reverts commit d8d7381.
  • Loading branch information
marcelstoer authored and Konrad Eisele committed Jan 7, 2018
1 parent 52124e1 commit 6be6132
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions app/http/httpclient.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,23 +215,20 @@ static void ICACHE_FLASH_ATTR http_connect_callback( void * arg )
ua_len = strlen(ua_header);
}

char * host_header = "";
char host_header[32] = "";
int host_len = 0;
if ( os_strstr( req->headers, "Host:" ) == NULL && os_strstr( req->headers, "host:" ) == NULL)
{
int max_header_len = 9 + strlen(req->hostname); // 9 is fixed size of "Host:[space][cr][lf]\0"
if ((req->port == 80)
#ifdef CLIENT_SSL_ENABLE
|| ((req->port == 443) && ( req->secure ))
#endif
)
{
host_header = alloca(max_header_len);
os_sprintf( host_header, "Host: %s\r\n", req->hostname );
}
else
{
host_header = alloca(max_header_len + 6); // 6 is worst case of ":port" where port is maximum 5 digits
os_sprintf( host_header, "Host: %s:%d\r\n", req->hostname, req->port );
}
host_len = strlen(host_header);
Expand Down

0 comments on commit 6be6132

Please sign in to comment.