host field in HTTP header is no longer limited to 31 charcters #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelstoer
requested changes
Dec 22, 2017
There was a problem hiding this comment.
Please add comments to the code to document how you arrived at that "+ 9/6" chars logic.
No documentation changes
Not anymore - we could/should have documented the limit you just removed 😜
this is just a bug fix
Not sure if it qualifies as a bug. Limiting to a (fairly small) fixed length seems questionable, though.
|
I had to revert it because this
ain't true. Please resubmit. |
|
yep. my bad
|
eiselekd
pushed a commit
to eiselekd/nodemcu-firmware
that referenced
this pull request
Jan 7, 2018
…cu#2205) * host field in HTTP header is no longer limited to 31 charcters * added description for magic values
eiselekd
pushed a commit
to eiselekd/nodemcu-firmware
that referenced
this pull request
Jan 7, 2018
nodemcu#2205)" (nodemcu#2208) This reverts commit d8d7381.
vsky279
pushed a commit
to vsky279/nodemcu-firmware
that referenced
this pull request
Sep 8, 2018
nodemcu#2205)" (nodemcu#2208) This reverts commit d8d7381.
andyleap
pushed a commit
to andyleap/nodemcu-firmware
that referenced
this pull request
Nov 26, 2018
nodemcu#2205)" (nodemcu#2208) This reverts commit d8d7381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2202
devbranch rather than formaster.see test cases in #2202