Add reaching definitions analysis #181

al3xliu · 2022-02-23T15:14:31Z

No description provided.

al3xliu · 2022-02-24T03:35:19Z

I think I need to change the test case to let the image adjust the pdf...

…uild.gradle under dataflow

wmdietl

A first round of comments.

dataflow/build.gradle

dataflow/src/test/java/reachDefs/ReachDefinitions.java

...w/src/main/java/org/checkerframework/dataflow/reachdefinitions/ReachDefinitionsTransfer.java

zcai1

Thanks for addressing my previous feedback. Maybe you can also take a look at my comments in #177 because these two PRs have similar structure.

dataflow/manual/content.tex

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsStore.java

...main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsTransfer.java

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsValue.java

dataflow/tests/reachingdefinitions/Test.java

wmdietl

File .gitignore needs to add the new generated files as ignorable. After running the tests, git status shouldn't show Out.txt and the class files in the new test directory as new.

dataflow/manual/content.tex

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsStore.java

...main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsTransfer.java

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsValue.java

dataflow/src/test/java/reachingdefinitions/ReachingDefinitions.java

…eFlowAnalysis() (eisop#199)

…uild.gradle under dataflow

…o rd

dataflow/tests/reach-definition/Expected.txt

wmdietl

Thanks! Another round of comments.

dataflow/manual/examples/ReachSimple.java

dataflow/build.gradle

dataflow/manual/content.tex

wmdietl · 2022-04-27T01:46:10Z

...src/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsNode.java

+
+/**
+ * A ReachingDefinitionsNode contains a CFG node, which can only be a AssignmentNode. It is used to
+ * represent the estimate of reaching definitions at certain CFG block during dataflow analysis. We


The plural in reaching definitions is odd, as there is only a single AssignmentNode field. So should this be singular, in the description and class name?

Yes, thanks!

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsStore.java

wmdietl · 2022-04-27T01:47:56Z

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsStore.java

+            ReachingDefinitionsNode generatedDefNode = it.next();
+            // It's preferred to use "==" to compare two nodes in checker framework,
+            // but in this case we use `equals` to only measure value equality.
+            // If we use "==", two expressions from different nodes with same


Can you try to reword? Something reads odd here.

wmdietl · 2022-04-27T01:48:33Z

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsStore.java

+    }
+
+    /**
+     * Add the information of a reaching definition into the reaching definitions set.


Suggested change

* Add the information of a reaching definition into the reaching definitions set.

* Add a reaching definition to the reaching definitions set.

wmdietl · 2022-04-27T01:49:04Z

...rc/main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsStore.java

+    /** We do not call widenedUpperBound in this analysis. */
+    @Override
+    public ReachingDefinitionsStore widenedUpperBound(ReachingDefinitionsStore previous) {
+        throw new BugInCF("wub of reaching definitions get called!");


Odd wording.

Thanks! According to BusyExpr, I removed it.

...main/java/org/checkerframework/dataflow/reachingdefinitions/ReachingDefinitionsTransfer.java

wmdietl

Thanks!
In the end run ./gradlew reformat to fix the formatting issues.

.gitignore

dataflow/src/main/java/org/checkerframework/dataflow/reachingdef/ReachingDefinitionStore.java

dataflow/manual/content.tex

wmdietl

Thanks!

dataflow/src/main/java/org/checkerframework/dataflow/reachingdef/ReachingDefinitionStore.java

add reach definition in dfa wild vaild contributor

f75c2a0

al3xliu mentioned this pull request Feb 23, 2022

add reach def in dfa #179

Closed

add reach definition documentation

f927242

AndrewShf and others added 6 commits February 25, 2022 13:30

Define a reusable dataflow test task (eisop#180)

f508945

add reach definition in dfa wild vaild contributor

df69b8e

rename reach definition to reach definitions;refine related task in b…

df6e558

…uild.gradle under dataflow

refine build.gradle

c6d457f

Merge branch 'master' into rd

0cdd601

rename reach definitions to reaching definitions

7e44391

wmdietl reviewed Feb 25, 2022

View reviewed changes

wmdietl assigned al3xliu Feb 25, 2022

al3xliu added 2 commits February 25, 2022 17:22

resolve comments v1

35c85af

update doc

65861b3

zcai1 reviewed Mar 1, 2022

View reviewed changes

wmdietl changed the title ~~add reach definition in dfa wild vaild contributor~~ Add reaching definitions analysis Mar 1, 2022

al3xliu and others added 2 commits March 1, 2022 15:46

refine doc and kill method in ReachingDefinitionsStore

8891601

Merge branch 'master' into rd

2855ee4

wmdietl requested changes Mar 23, 2022

View reviewed changes

wmdietl and others added 11 commits March 27, 2022 12:25

Decode element annotations on variable declarations (eisop#193)

c46edeb

Bump de.undercouch.download from 5.0.1 to 5.0.2 (eisop#192)

e62f332

Deprecate StringConcatenateAssignmentNode (eisop#183)

65140c7

Delete SKIP-REQUIRE-JAVADOC

1c5482c

Prep for release

34a041a

new release 3.21.3-eisop1

5e913c7

Prepare for next release

565e41c

Fix IllegalArgumentException caused by mismatch of arguments in creat…

512433b

…eFlowAnalysis() (eisop#199)

add reach definition in dfa wild vaild contributor

84bc01f

Define a reusable dataflow test task (eisop#180)

3ea09c2

rename reach definition to reach definitions;refine related task in b…

5e243f5

…uild.gradle under dataflow

al3xliu and others added 14 commits March 28, 2022 14:55

refine build.gradle

461581d

rename reach definitions to reaching definitions

de09c6d

resolve comments v1

3c8f295

Define a reusable dataflow test task (eisop#180)

7403a1b

rename reach definition to reach definitions;refine related task in b…

5685e87

…uild.gradle under dataflow

refine build.gradle

8c19982

rename reach definitions to reaching definitions

2c47aab

resolve comments v1

9b22f16

undo useless changes in build.gradle

6d33836

Merge branch 'rd' of https://github.com/al3xliu/checker-framework int…

b188600

…o rd

dont review now

3f88898

fix comments except manual

18901f1

reword documentation and add playground

6ece7c4

fix error

ae1017d

wmdietl reviewed Mar 29, 2022

View reviewed changes

dataflow/tests/reach-definition/Expected.txt Outdated Show resolved Hide resolved

complete rd test case;add explaination of equal;rm useless weird file

e1db1f8

AndrewShf mentioned this pull request Mar 31, 2022

Add UnusedAbstractValue and improve LiveVarAnalysis #203

Merged

al3xliu and others added 4 commits April 11, 2022 16:33

Merge branch 'eisop:master' into rd

12afcb6

make it compatable with ununsedvalue

9f42fec

Merge branch 'master' into rd

d1cdb55

Merge branch 'master' into rd

e47438c

wmdietl reviewed Apr 27, 2022

View reviewed changes

al3xliu added 2 commits April 27, 2022 18:24

fix comments from werner 0427

650251a

fix type

12caa52

wmdietl reviewed Apr 28, 2022

View reviewed changes

fix comments fromm werner 0428

5b04db0

wmdietl approved these changes Apr 29, 2022

View reviewed changes

dataflow/src/main/java/org/checkerframework/dataflow/reachingdef/ReachingDefinitionStore.java Outdated Show resolved Hide resolved

wmdietl added 2 commits April 28, 2022 20:34

Fix wording

619c1f3

Merge branch 'master' into rd

79c207d

wmdietl merged commit 66200c2 into eisop:master Apr 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add reaching definitions analysis #181

Add reaching definitions analysis #181

al3xliu commented Feb 23, 2022

al3xliu commented Feb 24, 2022

wmdietl left a comment

zcai1 left a comment

wmdietl left a comment

wmdietl left a comment

wmdietl Apr 27, 2022

al3xliu Apr 27, 2022

wmdietl Apr 27, 2022

al3xliu Apr 27, 2022

wmdietl Apr 27, 2022

wmdietl Apr 27, 2022

al3xliu Apr 27, 2022

wmdietl left a comment •

edited

Loading

wmdietl left a comment

	* Add the information of a reaching definition into the reaching definitions set.
	* Add a reaching definition to the reaching definitions set.

Add reaching definitions analysis #181

Add reaching definitions analysis #181

Conversation

al3xliu commented Feb 23, 2022

al3xliu commented Feb 24, 2022

wmdietl left a comment

Choose a reason for hiding this comment

zcai1 left a comment

Choose a reason for hiding this comment

wmdietl left a comment

Choose a reason for hiding this comment

wmdietl left a comment

Choose a reason for hiding this comment

wmdietl Apr 27, 2022

Choose a reason for hiding this comment

al3xliu Apr 27, 2022

Choose a reason for hiding this comment

wmdietl Apr 27, 2022

Choose a reason for hiding this comment

al3xliu Apr 27, 2022

Choose a reason for hiding this comment

wmdietl Apr 27, 2022

Choose a reason for hiding this comment

wmdietl Apr 27, 2022

Choose a reason for hiding this comment

al3xliu Apr 27, 2022

Choose a reason for hiding this comment

wmdietl left a comment • edited Loading

Choose a reason for hiding this comment

wmdietl left a comment

Choose a reason for hiding this comment

wmdietl left a comment •

edited

Loading