Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnusedAbstractValue and improve LiveVarAnalysis #203

Merged
merged 16 commits into from
Apr 10, 2022
Merged

Add UnusedAbstractValue and improve LiveVarAnalysis #203

merged 16 commits into from
Apr 10, 2022

Conversation

AndrewShf
Copy link
Member

@AndrewShf AndrewShf commented Mar 31, 2022 •
edited
Loading

Apply suggestions in
#177
#181
to LiveVarAnalysis as well.

Add the UnusedAbstractValue class.

@AndrewShf AndrewShf requested a review from wmdietl March 31, 2022 18:31
wmdietl
wmdietl requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few small comments.

@zcai1 zcai1 assigned zcai1 and unassigned zcai1 Apr 1, 2022
@zcai1 zcai1 self-requested a review April 1, 2022 17:59
@AndrewShf AndrewShf changed the title add UnusedAbsValue, improve LiveVarAnalysis add UnusedAbstractValue, improve LiveVarAnalysis Apr 1, 2022
zcai1
zcai1 reviewed Apr 2, 2022
View reviewed changes
zcai1
zcai1 reviewed Apr 2, 2022
View reviewed changes
zcai1
zcai1 reviewed Apr 2, 2022
View reviewed changes
@wmdietl wmdietl changed the title add UnusedAbstractValue, improve LiveVarAnalysis Add UnusedAbstractValue and improve LiveVarAnalysis Apr 4, 2022
wmdietl
wmdietl approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few small suggestions.

wmdietl
wmdietl approved these changes Apr 10, 2022
View reviewed changes
@wmdietl wmdietl enabled auto-merge (squash) April 10, 2022 22:53
@wmdietl wmdietl merged commit 4a1e09d into eisop:master Apr 10, 2022
AndrewShf pushed a commit to AndrewShf/checker-framework that referenced this pull request Apr 11, 2022
@wmdietl
Reformat with updated GJF (eisop#203)
43e8977
AndrewShf added a commit to AndrewShf/checker-framework that referenced this pull request Apr 20, 2022
@AndrewShf @wmdietl @zcai1
Add UnusedAbstractValue and improve LiveVarAnalysis (eisop#203)
5334f0d 
Co-authored-by: Werner Dietl <wdietl@gmail.com>
Co-authored-by: zcai <z44cai@uwaterloo.ca>
@AndrewShf AndrewShf mentioned this pull request Apr 21, 2022
Closed
@AndrewShf AndrewShf deleted the liveVar_and_UnusedAbsVal branch September 17, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcai1 zcai1 zcai1 left review comments

@wmdietl wmdietl wmdietl approved these changes

Assignees

@AndrewShf AndrewShf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewShf @wmdietl @zcai1