Don't erase the type argument of receiver

[Ao-senXiong]

Also fixes #104

for this code

public class Test<T> {
   Test <T> a;

    Test() {
        a = new Test<>();
        foo();
    }

    void foo() {}
}

error message before the change:

Test.java:6: error: [method.invocation.invalid] call to foo() not allowed on the given receiver.
        foo();
           ^
  found   : @UnderInitialization(Test.class) Test</*RAW*/>
  required: @Initialized Test</*RAW*/>

error message after the change:

Test.java:6: error: [method.invocation.invalid] call to foo() not allowed on the given receiver.
        foo();
           ^
  found   : @UnderInitialization(Test.class) Test<T extends @Initialized Object>
  required: @Initialized Test<T extends @Initialized Object>
1 error

[wmdietl]

As discussed, please add a jtreg test.

[wmdietl]

Maybe this would fix #104? Can you try with tests from that issue?

[Ao-senXiong]

Maybe this would fix #104? Can you try with tests from that issue?

Just checked, this did not fix it.

[wmdietl]

Thanks for starting to look into this. We should look at this properly and fix #104 while we touch this code.

[wmdietl]

TypeArgument is not a very descriptive name for this test.

[Ao-senXiong]

Renamed to NonRawTypeArgumentTest

[wmdietl]

I find this summary confusing and don't see how this matches the code - there is no type argument there.
You need to say something about what type argument you mean.
Same with the test name 'NonRawTypeArgument` isn't very helpful - all type arguments are non-raw, otherwise there wouldn't be type arguments...

[Ao-senXiong]

This is a partial fix, look into the error message in subclass and #104

[Ao-senXiong]

#104 seems like really different issue after I debugging the code. Maybe we should merge this independently.

[Ao-senXiong]

This f66d93d also fixes #104 now.

@wmdietl I am wondering why we have three local variables here?

checker-framework/framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java

Lines 3775 to 3777 in 3081b3a

	AnnotatedTypeMirror methodReceiver = method.getReceiverType().getErased();
	AnnotatedTypeMirror treeReceiver = methodReceiver.shallowCopy(false);
	AnnotatedTypeMirror rcv = atypeFactory.getReceiverType(tree);

I think we can only use two, one for the actual receiver invoke the method and one from the method signature.

Otherwise, we need to change shallow copy because currently it also copy the annotation for type argument regardless the boolean flag.

checker-framework/framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeMirror.java

Lines 1147 to 1153 in 3081b3a

	AnnotatedDeclaredType type =
	new AnnotatedDeclaredType(getUnderlyingType(), atypeFactory, declaration);
	if (copyAnnotations) {
	type.addAnnotations(this.getAnnotationsField());
	}
	type.setEnclosingType(getEnclosingType());
	type.setTypeArguments(getTypeArguments());

[Ao-senXiong]

The errors in CI are interesting:
plume-lib: This looks like error reporting use the same ATM.

> Compilation failed; see the compiler output below.
  Note: Checker Framework 3.42.0-eisop5-SNAPSHOT, branch HEAD, 2024-12-18, commit bd34749, dirty=true
  /tmp/plume-util/src/main/java/org/plumelib/util/ArraysPlume.java:1714: error: [nullness:method.invocation.invalid] call to toArray() not allowed on the given receiver.
      T[] asArray = (T[]) lst.toArray();
                                     ^
    found   : @NonNull List<T extends @Nullable Object>
    required: @NonNull List<T extends @Nullable Object>
  1 error

Daikon-part1: This looks like it fails because of handling wildcard.

daikon/Quant.java:11450: error: [nullness:method.invocation.invalid] call to toArray() not allowed on the given receiver.
      return java.lang.reflect.Array.get(((java.util.AbstractCollection<?>)o).toArray(), (int)i);
                                                                                     ^
  found   : @NonNull AbstractCollection<? extends @Nullable Object>
  required: @NonNull AbstractCollection<capture#09 extends @Nullable Object>
daikon/Quant.java:12162: error: [nullness:method.invocation.invalid] call to toArray() not allowed on the given receiver.
      return (String)java.lang.reflect.Array.get(((java.util.AbstractCollection<?>)o).toArray(), (int)i);
                                                                                             ^
  found   : @NonNull AbstractCollection<? extends @Nullable Object>
  required: @NonNull AbstractCollection<capture#010 extends @Nullable Object>
10 errors
make: *** [Makefile:922: typecheck-nullness] Error 1
make: Leaving directory '/home/runner/work/checker-framework/daikon/java'