forked from typetools/checker-framework
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't erase the type argument of receiver #793
Open
Ao-senXiong
wants to merge
15
commits into
eisop:master
Choose a base branch
from
Ao-senXiong:type-argument
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−6
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ed8e47f
Don't erase the type on the receiver
Ao-senXiong ab59a90
Merge branch 'master' into type-argument
Ao-senXiong 0df34f6
Add jtreg test case
Ao-senXiong 997dc5d
Merge branch 'master' into type-argument
Ao-senXiong 82c9faa
Empty commit for CI
Ao-senXiong e160b61
Delete extra folder and rename the file
Ao-senXiong a5d1fad
Rename the test file and refine the summary
Ao-senXiong a4387a1
Merge branch 'master' into type-argument
Ao-senXiong 053340d
Merge branch 'master' into type-argument
Ao-senXiong 91dd74f
Merge branch 'master' into type-argument
Ao-senXiong 5768f2c
Merge branch 'master' into type-argument
Ao-senXiong c6afb70
Merge branch 'master' into type-argument
Ao-senXiong b7f5767
Subclass receiver test
Ao-senXiong f66d93d
Also fixes 104
Ao-senXiong 714b75a
Update expected output
Ao-senXiong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* | ||
* @test | ||
* @summary Test case for type argument in method invocation. | ||
* | ||
* @compile/fail/ref=NonRawTypeArgumentTest.out -XDrawDiagnostics -processor org.checkerframework.checker.nullness.NullnessChecker NonRawTypeArgumentTest.java | ||
*/ | ||
public class NonRawTypeArgumentTest<T> { | ||
|
||
NonRawTypeArgumentTest() { | ||
foo(); | ||
} | ||
|
||
void foo() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
NonRawTypeArgumentTest.java:10:12: compiler.err.proc.messager: [method.invocation.invalid] call to foo() not allowed on the given receiver. | ||
found : @UnderInitialization(NonRawTypeArgumentTest.class) NonRawTypeArgumentTest<T extends @Initialized Object> | ||
required: @Initialized NonRawTypeArgumentTest<T extends @Initialized Object> | ||
1 error |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this summary confusing and don't see how this matches the code - there is no type argument there.
You need to say something about what type argument you mean.
Same with the test name 'NonRawTypeArgument` isn't very helpful - all type arguments are non-raw, otherwise there wouldn't be type arguments...