Skip to content

Commit

Permalink
netty-shaded: Use compile instead of runtime dep in pom for core
Browse files Browse the repository at this point in the history
This is essentially re-adding grpc#5901 after its behavior was "reverted"
in grpc#8242. At the time grpc-core was the only dependency, so this change
only applies to grpc-core to make it a tiny bit easier to swap to
runtime scope in the future.
  • Loading branch information
ejona86 committed Jun 17, 2021
1 parent 5642e01 commit 25788df
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions netty/shaded/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,19 @@ publishing {
artifact javadocJar
artifact sourcesJar

// Avoid confusing error message "class file for
// io.grpc.internal.AbstractServerImplBuilder not found"
// (https://github.com/grpc/grpc-java/issues/5881). This can be
// removed after https://github.com/grpc/grpc-java/issues/7211 is
// resolved.
pom.withXml {
asNode().dependencies.'*'.findAll() { dep ->
dep.artifactId.text() == 'grpc-core'
}.each() { core ->
core.scope*.value = "compile"
}
}

// shadow.component() is run after the main build.gradle's withXml
pom.withXml {
asNode().dependencies.'*'.findAll() { dep ->
Expand Down

0 comments on commit 25788df

Please sign in to comment.