Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty/shaded: Leverage shadow plugin's publishing support #8242

Merged
merged 1 commit into from
Jun 11, 2021
Merged

netty/shaded: Leverage shadow plugin's publishing support #8242

merged 1 commit into from
Jun 11, 2021

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jun 7, 2021

GradleUp/shadow#543 fixed project support,
which means the workaround is no longer necessary.

@ejona86
netty/shaded: Leverage shadow plugin's publishing support
1e9218f 
GradleUp/shadow#543 fixed project support,
which means the workaround is no longer necessary.
@ejona86 ejona86 requested a review from dapengzhang0 June 7, 2021 17:30
dapengzhang0
dapengzhang0 approved these changes Jun 10, 2021
View reviewed changes
netty/shaded/build.gradle Show resolved Hide resolved
dapengzhang0
dapengzhang0 approved these changes Jun 10, 2021
View reviewed changes
netty/shaded/build.gradle Show resolved Hide resolved
@ejona86 ejona86 merged commit 8360e60 into grpc:master Jun 11, 2021
@ejona86 ejona86 deleted the shadow-publishing branch June 11, 2021 15:32
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jun 17, 2021
@ejona86
netty-shaded: Use compile instead of runtime dep in pom for core
25788df 
This is essentially re-adding grpc#5901 after its behavior was "reverted"
in grpc#8242. At the time grpc-core was the only dependency, so this change
only applies to grpc-core to make it a tiny bit easier to swap to
runtime scope in the future.
@ejona86 ejona86 mentioned this pull request Jun 17, 2021
Merged
ejona86 added a commit that referenced this pull request Jun 18, 2021
@ejona86
netty-shaded: Use compile instead of runtime dep in pom for core
2258d2e 
This is essentially re-adding #5901 after its behavior was "reverted"
in #8242. At the time grpc-core was the only dependency, so this change
only applies to grpc-core to make it a tiny bit easier to swap to
runtime scope in the future.
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jun 18, 2021
@ejona86
netty-shaded: Use compile instead of runtime dep in pom for core
5dd72b4 
This is essentially re-adding grpc#5901 after its behavior was "reverted"
in grpc#8242. At the time grpc-core was the only dependency, so this change
only applies to grpc-core to make it a tiny bit easier to swap to
runtime scope in the future.
@ejona86 ejona86 mentioned this pull request Jun 18, 2021
Merged
ejona86 added a commit that referenced this pull request Jun 18, 2021
@ejona86
netty-shaded: Use compile instead of runtime dep in pom for core
e77561a 
This is essentially re-adding #5901 after its behavior was "reverted"
in #8242. At the time grpc-core was the only dependency, so this change
only applies to grpc-core to make it a tiny bit easier to swap to
runtime scope in the future.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejona86 @dapengzhang0