-
Notifications
You must be signed in to change notification settings - Fork 539
systemtest: wait for geoIP database availability #7272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If anyone cares, this can be tested by temporarily disabling the geoIP downloader: This clears out the cached databases. After setting it back to "true", they will be fetched again. |
marclop
approved these changes
Feb 14, 2022
Contributor
marclop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
(cherry picked from commit ec38207)
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
(cherry picked from commit ec38207)
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
(cherry picked from commit ec38207) # Conflicts: # systemtest/containers.go
axw
added a commit
that referenced
this pull request
Feb 14, 2022
axw
added a commit
that referenced
this pull request
Feb 15, 2022
stuartnelson3
added a commit
to stuartnelson3/apm-server
that referenced
this pull request
May 6, 2022
This reverts commit ec38207.
stuartnelson3
added a commit
that referenced
this pull request
May 6, 2022
axw
pushed a commit
that referenced
this pull request
May 16, 2022
* mount static geoip db into es container fixes flaky test that depended on the geoip db being downloaded. closes #7260 * Revert "systemtest: wait for geoIP database availability (#7272)" This reverts commit ec38207. (cherry picked from commit dc846d9) Co-authored-by: stuart nelson <stuartnelson3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7.17
Automated backport with mergify to the 7.17 branch
backport-8.0
Automated backport with mergify
backport-8.1
Automated backport with mergify
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Elasticsearch downloads the geoIP database after starting up, and then refreshes it periodically. In CI the cluster will always be fresh, so we wait for the database to be downloaded before running any tests which may depend on the database being available.
Checklist
N/A
How to test these changes
N/A
Related issues
Closes #7260