Skip to content

Conversation

@axw
Copy link
Member

@axw axw commented Feb 14, 2022

Motivation/summary

Elasticsearch downloads the geoIP database after starting up, and then refreshes it periodically. In CI the cluster will always be fresh, so we wait for the database to be downloaded before running any tests which may depend on the database being available.

Checklist

N/A

How to test these changes

N/A

Related issues

Closes #7260

@axw axw added backport-8.0 Automated backport with mergify backport-8.1 Automated backport with mergify backport-7.17 Automated backport with mergify to the 7.17 branch labels Feb 14, 2022
@axw axw requested a review from a team February 14, 2022 03:22
@axw
Copy link
Member Author

axw commented Feb 14, 2022

If anyone cares, this can be tested by temporarily disabling the geoIP downloader:

PUT /_cluster/settings?flat_settings=true
{
  "transient" : {
    "ingest.geoip.downloader.enabled" : "false"
  }
}

This clears out the cached databases. After setting it back to "true", they will be fetched again.

Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@axw axw enabled auto-merge (squash) February 14, 2022 03:33
@ghost
Copy link

ghost commented Feb 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-14T03:22:07.871+0000

  • Duration: 63 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 5634
Skipped 19
Total 5653

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@axw axw merged commit ec38207 into elastic:main Feb 14, 2022
mergify bot pushed a commit that referenced this pull request Feb 14, 2022
mergify bot pushed a commit that referenced this pull request Feb 14, 2022
mergify bot pushed a commit that referenced this pull request Feb 14, 2022
(cherry picked from commit ec38207)

# Conflicts:
#	systemtest/containers.go
@axw axw deleted the systemtest-wait-geip branch February 14, 2022 04:57
axw added a commit that referenced this pull request Feb 14, 2022
(cherry picked from commit ec38207)

Co-authored-by: Andrew Wilkins <axw@elastic.co>
axw added a commit that referenced this pull request Feb 15, 2022
… (#7277)

* systemtest: wait for geoIP database availability (#7272)

(cherry picked from commit ec38207)

* go mod tidy

* Fix go.sum

Co-authored-by: Andrew Wilkins <axw@elastic.co>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
axw added a commit that referenced this pull request Feb 15, 2022
…) (#7278)

* systemtest: wait for geoIP database availability (#7272)

(cherry picked from commit ec38207)

# Conflicts:
#	systemtest/containers.go

* Fix merge conflict

Co-authored-by: Andrew Wilkins <axw@elastic.co>
stuartnelson3 added a commit to stuartnelson3/apm-server that referenced this pull request May 6, 2022
stuartnelson3 added a commit that referenced this pull request May 6, 2022
* mount static geoip db into es container

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

* Revert "systemtest: wait for geoIP database availability (#7272)"

This reverts commit ec38207.
mergify bot pushed a commit that referenced this pull request May 16, 2022
* mount static geoip db into es container

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

* Revert "systemtest: wait for geoIP database availability (#7272)"

This reverts commit ec38207.

(cherry picked from commit dc846d9)
mergify bot pushed a commit that referenced this pull request May 16, 2022
* mount static geoip db into es container

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

* Revert "systemtest: wait for geoIP database availability (#7272)"

This reverts commit ec38207.

(cherry picked from commit dc846d9)

# Conflicts:
#	systemtest/containers.go
axw pushed a commit that referenced this pull request May 16, 2022
* mount static geoip db into es container

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

* Revert "systemtest: wait for geoIP database availability (#7272)"

This reverts commit ec38207.

(cherry picked from commit dc846d9)

Co-authored-by: stuart nelson <stuartnelson3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.0 Automated backport with mergify backport-8.1 Automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

systemtest: ensure geoIP database is available before running tests

2 participants