Skip to content

Conversation

@stuartnelson3
Copy link
Contributor

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

I suppose the way to test this would be to run it several times?

fixes flaky test that depended on the geoip db
being downloaded.

closes elastic#7260
@stuartnelson3 stuartnelson3 requested a review from a team May 6, 2022 09:49
@mergify
Copy link
Contributor

mergify bot commented May 6, 2022

This pull request does not have a backport label. Could you fix it @stuartnelson3? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 6, 2022
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, thanks :)

Can you please revert b5d52d7 as part of this PR?

@ghost
Copy link

ghost commented May 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-06T11:36:11.605+0000

  • Duration: 29 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 3981
Skipped 13
Total 3994

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link

ghost commented May 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (43/43) 💚
Files 91.919% (182/198) 👍
Classes 93.421% (426/456) 👍
Methods 89.3% (1085/1215) 👍
Lines 76.895% (13179/17139) 👍 0.047
Conditionals 100.0% (0/0) 💚

@stuartnelson3 stuartnelson3 enabled auto-merge (squash) May 6, 2022 11:36
@stuartnelson3 stuartnelson3 merged commit dc846d9 into elastic:main May 6, 2022
@stuartnelson3 stuartnelson3 deleted the static-geoip-database branch May 6, 2022 12:06
@stuartnelson3 stuartnelson3 added backport-8.3 Automated backport with mergify and removed backport-8.3 Automated backport with mergify labels May 6, 2022
@marclop
Copy link
Contributor

marclop commented May 9, 2022

shouldn't we back port this to 8.2, 8.1 and 7.17, to avoid having these failures happening regularly?

@axw axw added backport-8.2 Automated backport with mergify backport-7.17 Automated backport with mergify to the 7.17 branch and removed backport-skip Skip notification from the automated backport with mergify labels May 16, 2022
mergify bot pushed a commit that referenced this pull request May 16, 2022
* mount static geoip db into es container

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

* Revert "systemtest: wait for geoIP database availability (#7272)"

This reverts commit ec38207.

(cherry picked from commit dc846d9)
mergify bot pushed a commit that referenced this pull request May 16, 2022
* mount static geoip db into es container

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

* Revert "systemtest: wait for geoIP database availability (#7272)"

This reverts commit ec38207.

(cherry picked from commit dc846d9)

# Conflicts:
#	systemtest/containers.go
@axw
Copy link
Member

axw commented May 16, 2022

Don't need 8.1 since 8.2.0 is released, but yes for the others.

axw pushed a commit that referenced this pull request May 16, 2022
* mount static geoip db into es container

fixes flaky test that depended on the geoip db
being downloaded.

closes #7260

* Revert "systemtest: wait for geoIP database availability (#7272)"

This reverts commit ec38207.

(cherry picked from commit dc846d9)

Co-authored-by: stuart nelson <stuartnelson3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.2 Automated backport with mergify test-plan-skip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

systemtest: ensure geoIP database is available before running tests

4 participants