Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jolokia autodiscover fields are not documented #10925

Closed
jsoriano opened this issue Feb 25, 2019 · 1 comment
Closed

Jolokia autodiscover fields are not documented #10925

jsoriano opened this issue Feb 25, 2019 · 1 comment
Assignees
@kaiyan-sheng
Labels
bug docs libbeat Team:Integrations Label for the Integrations team

Comments

@jsoriano
Copy link
Member

jsoriano commented Feb 25, 2019 •
edited by alvarolobato
Loading

As part of #10898 we tried to enable checks for documented fields also for Jolokia autodiscover provider, and we found that the fields injected by it are not documented.

'jolokia.agent.version' found in event is not documented

We should add them to some fields definition file. At the moment there are not fields definition files in autodiscover providers. Fields in other providers are covered by common docker and kubernetes fields, but this doesn't happen to Jolokia.
@jsoriano jsoriano added bug docs libbeat Team:Integrations Label for the Integrations team labels Feb 25, 2019
@jsoriano jsoriano mentioned this issue Feb 25, 2019
Merged
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 25, 2019
@kaiyan-sheng
Copy link
Contributor

This error showed up after self.assert_fields_are_documented(output[0]) is added into test.

@kaiyan-sheng kaiyan-sheng mentioned this issue Feb 28, 2019
Merged
@jsoriano jsoriano mentioned this issue Mar 26, 2019
Merged
jsoriano added a commit that referenced this issue Mar 27, 2019
@jsoriano
Add autodiscover to libbeat modules list in fields generator (#11474)
8f1fa59 
Add autodiscover providers to the list of libbeat modules in fields
generator.

Move jolokia autodiscover fields added in #10925 to the provider.
DStape pushed a commit to DStape/beats that referenced this issue Aug 20, 2019
@jsoriano
Add autodiscover to libbeat modules list in fields generator (elastic…
ff1256d 
…#11474)

Add autodiscover providers to the list of libbeat modules in fields
generator.

Move jolokia autodiscover fields added in elastic#10925 to the provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaiyan-sheng kaiyan-sheng

Labels
bug docs libbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsoriano @kaiyan-sheng