Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autodiscover to libbeat modules list in fields generator #11474

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Mar 26, 2019

Add autodiscover providers to the list of libbeat modules in fields
generator, so autodiscover providers can define their own fields
as processors do.

Move jolokia autodiscover fields added in #10925 to the provider.

Add autodiscover providers to the list of libbeat modules in fields
generator.
@jsoriano jsoriano added review libbeat Team:Integrations Label for the Integrations team labels Mar 26, 2019
@jsoriano jsoriano requested review from a team as code owners March 26, 2019 14:20
@jsoriano jsoriano self-assigned this Mar 26, 2019
@jsoriano jsoriano merged commit 8f1fa59 into elastic:master Mar 27, 2019
@jsoriano jsoriano deleted the jolokia-common-autodiscover-fields branch March 27, 2019 13:43
@graphaelli
Copy link
Member

Do these fields really make sense for all beats?

@ruflin
Copy link
Member

ruflin commented Mar 28, 2019

@graphaelli I think we need to ask the question differently: Does Jolokia autodiscovery make sense for all Beats (and with it the fields). Right now all autodiscovery providers are available in all Beats. I agree that this is something we should potentially change. Then only the Beats that use the provider, also have the fields.

@graphaelli
Copy link
Member

I think we need to ask the question differently: Does Jolokia autodiscovery make sense for all Beats

I was actually being deliberate there. I'm pretty sure the answer to your version is no. However, apm-server has inherited fields from libbeat that are not relevant to it for awhile and simply not filled them in. In other cases, fields are inherited and filled in differently than they might be in other beats, for example those defined by the host metadata processor.

This change opens the door to many more of those kinds of fields, that is those specific to only certain types of beats, and I figured I'd start a discussion on whether that makes sense. For now in apm-server, I've proposed we ignore all autodiscover fields for now.

@ruflin
Copy link
Member

ruflin commented Mar 29, 2019

@graphaelli +1 on having this discussion. Do you mind opening a separate issue for it?

Did not check the apm-server code in detail, but does it mean all the autodiscovery code is removed or only the fields?

@graphaelli
Copy link
Member

#11535 to continue the discussion. APM server currently omits autodiscovery documentation and fields only, not code.

DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
…#11474)

Add autodiscover providers to the list of libbeat modules in fields
generator.

Move jolokia autodiscover fields added in elastic#10925 to the provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants