Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAN (NATS streaming) module #14629

Closed
13 of 15 tasks
exekias opened this issue Nov 19, 2019 · 9 comments · Fixed by #16980
Closed
13 of 15 tasks

STAN (NATS streaming) module #14629

exekias opened this issue Nov 19, 2019 · 9 comments · Fixed by #16980
Assignees
Labels
candidate Candidate to be added to the current iteration enhancement module Team:Integrations Label for the Integrations team

Comments

@exekias
Copy link
Contributor

exekias commented Nov 19, 2019

@devon-kim implemented a new module for STAN (NATS streaming), thank you!. This issue is minded to try to include this module in the beats repo so everyone can benefit from it:

7.2...devon-kim:ops-1844-stan-metricbeat

Metricbeat Module / Dataset release checklist

This checklist is intended for Devs which create or update a module to make sure modules are consistent.

Modules

For a metricset to go GA, the following criterias should be met:

  • Supported versions are documented
  • Supported operating systems are documented (if applicable)
  • Integration tests exist
  • System tests exist
  • Automated checks that all fields are documented
  • Documentation
  • Fields follow ECS and naming conventions
  • Dashboards exists (if applicable)
  • Kibana Home Tutorial (if applicable) [Home][Tutorial] Add STAN data UI kibana#54102
    • Open issue in EUI repo to add icon for module if not already exists.
    • Open PR against Kibana repo with tutorial. Examples can be found here.

Filebeat module

  • Test log files exist for the grok patterns
  • Generated output for at least 1 log file exists

Metricbeat module

  • Example data.json exists and an automated way to generate it exists (go test -data)
  • Test environment in Docker exist for integration tests
@exekias exekias added enhancement module [zube]: Ready Team:Integrations Label for the Integrations team candidate Candidate to be added to the current iteration labels Nov 19, 2019
@exekias
Copy link
Contributor Author

exekias commented Nov 19, 2019

cc @andresrc

also @ChrsMark you may be interested, as you were involved in the NATS module

@ChrsMark
Copy link
Member

ChrsMark commented Jan 7, 2020

Giving an update on this, Kibana tutorial is on its road elastic/kibana#54102 and we are waiting for a the original dashboards.

cc: @devon-kim

@ChrsMark
Copy link
Member

Note that the Kibana tutorial should be updated with the dashboard screenshot when the dashboard is in.

@devon-kim
Copy link
Contributor

devon-kim commented Jan 15, 2020

@ChrsMark screenshot

So I have this screenshot and have exported the JS to generate it from Kibana and left it up as a gist since I'm not quite sure where the dashboard should go https://gist.github.com/devon-kim/9f0514616b0869e31e721d11ca997db4

@ChrsMark
Copy link
Member

Thanks @devon-kim! #14026 can be used as an example of how the dashboard should be added. Could you give it a try?

@ChrsMark
Copy link
Member

ChrsMark commented Jan 24, 2020

Kibana Tutorial link to dashobard PR (merged): elastic/kibana#55837

@ChrsMark
Copy link
Member

Thanks for contributing the Dashboard @devon-kim! Backports to 7.x and 7.6 are on the way!

@andresrc should we add the Dashboard to the test-plan for an extra check and then maybe the module can go to GA?

@andresrc
Copy link
Contributor

andresrc commented Mar 9, 2020

@ChrsMark what's missing here?

@ChrsMark
Copy link
Member

ChrsMark commented Mar 9, 2020

@andresrc we have already test it so I think it can go to GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate Candidate to be added to the current iteration enhancement module Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants