-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #14839 to 7.x: [Metricbeat] Add STAN (NATS streaming) module #15092
Conversation
(cherry picked from commit 10c741a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's only 7.x backport, feel free to merge it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid you will need to run also mage fmt update
(see Travis output).
Travis error is from time-outs now in heartbeat and the metricbeat test suites due to the test stdout being swallowed. Simple fix for the 7.x doc change otherwise. |
I restarted the failed jobs. We need to solve the conflict in Changelog. I propose we remove completely the docs link to avoid these issues. Wdyt? |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
What I said about removing docs is not correct. These files are auto generated. |
Cherry-pick of PR #14839 to 7.x branch. Original message:
This PR cherry-picks the commits of @devon-kim
from 7.2...devon-kim:ops-1844-stan-metricbeat so as to be merged to
beats/master
as part of #14629.cc: @exekias
Manual testing
docker build -t stan_test .
(run this command underx-pack/metricbeat/module/stan/_meta
)docker run -p 8222:8222 stan_test
(Note that default fetching period is 60secs, so this might should be changed for the testing)