Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #14839 to 7.x: [Metricbeat] Add STAN (NATS streaming) module #15092

Merged
merged 5 commits into from
Dec 16, 2019

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 13, 2019

Cherry-pick of PR #14839 to 7.x branch. Original message:

This PR cherry-picks the commits of @devon-kim
from 7.2...devon-kim:ops-1844-stan-metricbeat so as to be merged to beats/master as part of #14629.

cc: @exekias

Manual testing

  1. Build the Docker image: docker build -t stan_test . (run this command under x-pack/metricbeat/module/stan/_meta)
  2. Start STAN server: docker run -p 8222:8222 stan_test
  3. Enable the module and run Metricbeat.
    (Note that default fetching period is 60secs, so this might should be changed for the testing)

@ChrsMark ChrsMark requested a review from a team as a code owner December 13, 2019 08:21
@ChrsMark ChrsMark self-assigned this Dec 13, 2019
@zube zube bot unassigned ChrsMark Dec 13, 2019
@ChrsMark ChrsMark self-assigned this Dec 13, 2019
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it's only 7.x backport, feel free to merge it :)

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid you will need to run also mage fmt update (see Travis output).

@devon-kim devon-kim requested a review from mtojek December 13, 2019 19:37
@devon-kim
Copy link
Contributor

Travis error is from time-outs now in heartbeat and the metricbeat test suites due to the test stdout being swallowed. Simple fix for the 7.x doc change otherwise.

@ChrsMark
Copy link
Member Author

I restarted the failed jobs. We need to solve the conflict in Changelog. I propose we remove completely the docs link to avoid these issues. Wdyt?

@ChrsMark
Copy link
Member Author

I restarted the failed jobs. We need to solve the conflict in Changelog. I propose we remove completely the docs link to avoid these issues. Wdyt?

What I said about removing docs is not correct. These files are auto generated.

@ChrsMark ChrsMark merged commit 00c3c76 into elastic:7.x Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants