Custom index patterns not fully handled by dashboards

[andrewkroh]

There are two parts that are not being updated when setting a custom index pattern via setup.dashboards.index.

1. Timelion expressions containing index patterns are not updated. example
2. index-pattern references from dashboard objects are not updated. example

Regarding timelion, there's no code to update the expression with the new index pattern. I think that would belong in

beats/libbeat/dashboards/modify_json.go

Lines 126 to 155 in ad823ec

	func ReplaceIndexInVisState(index string, visStateJSON string) string {
	var visState map[string]interface{}
	err := json.Unmarshal([]byte(visStateJSON), &visState)
	if err != nil {
	logp.Err("Fail to unmarshal visState: %v", err)
	return visStateJSON
	}
	params, ok := visState["params"].(map[string]interface{})
	if !ok {
	return visStateJSON
	}
	// Don't set it if it was not set before
	if pattern, ok := params["index_pattern"].(string); !ok || len(pattern) == 0 {
	return visStateJSON
	}
	params["index_pattern"] = index
	d, err := json.Marshal(visState)
	if err != nil {
	logp.Err("Fail to marshal visState: %v", err)
	return visStateJSON
	}
	return string(d)
	}

And for the dashboard objects we need to update the references where type=index-pattern. I think that would belong in

beats/libbeat/dashboards/modify_json.go

Line 167 in ad823ec

for i, object := range objects {

Relates

• Dashboards display partially when using custom index (other than metricbeat*) #20703

[elasticmachine]

Pinging @elastic/integrations-services (Team:Services)

[elasticmachine]

Pinging @elastic/agent (Team:Agent)