Beats dashboard should use custom index patterns when setup.dashboards.index is set
#27901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
kvch
commented
Sep 13, 2021
x-pack/filebeat/module/cyberarkpas/_meta/kibana/7/dashboard/Filebeat-cyberarkpas-audit.json
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jsoriano
reviewed
Sep 14, 2021
x-pack/filebeat/module/aws/_meta/kibana/7/map/0edf0640-3e7e-11ea-bb0a-69c3ca1d410f.json
Show resolved
Hide resolved
x-pack/filebeat/module/cyberarkpas/_meta/kibana/7/dashboard/Filebeat-cyberarkpas-audit.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/cyberarkpas/_meta/kibana/7/dashboard/Filebeat-cyberarkpas-audit.json
Outdated
Show resolved
Hide resolved
jsoriano
approved these changes
Sep 14, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2021
…ds.index` is set (#27901) ## What does this PR do? This PR adds a new check to `make check` to make sure all dashboards can handle custom index names. It is the responsibility of the dashboard author to keep the dashboard useable if `setup.dashboards.index` is configured. The PR contains additional fixes to make sure existing dashboards can be used with custom index names. Also, the test coverage was increased as it is a quite big PR. The PR also decodes a few fields to make dashboards easier to review. ## Why is it important? The bug prevents users from setting custom index names and use our dashboards at the same time. Closes #21232 (cherry picked from commit 2328548) # Conflicts: # libbeat/dashboards/modify_json.go
kvch
added a commit
that referenced
this pull request
Sep 15, 2021
…ds.index` is set (#27901) This PR adds a new check to `make check` to make sure all dashboards can handle custom index names. It is the responsibility of the dashboard author to keep the dashboard useable if `setup.dashboards.index` is configured. The PR contains additional fixes to make sure existing dashboards can be used with custom index names. Also, the test coverage was increased as it is a quite big PR. The PR also decodes a few fields to make dashboards easier to review. The bug prevents users from setting custom index names and use our dashboards at the same time. Closes #21232 (cherry picked from commit 2328548)
kvch
added a commit
that referenced
this pull request
Sep 15, 2021
…ds.index` is set (#27901) (#27932) This PR adds a new check to `make check` to make sure all dashboards can handle custom index names. It is the responsibility of the dashboard author to keep the dashboard useable if `setup.dashboards.index` is configured. The PR contains additional fixes to make sure existing dashboards can be used with custom index names. Also, the test coverage was increased as it is a quite big PR. The PR also decodes a few fields to make dashboards easier to review. The bug prevents users from setting custom index names and use our dashboards at the same time. Closes #21232 (cherry picked from commit 2328548) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…ds.index` is set (elastic#27901) ## What does this PR do? This PR adds a new check to `make check` to make sure all dashboards can handle custom index names. It is the responsibility of the dashboard author to keep the dashboard useable if `setup.dashboards.index` is configured. The PR contains additional fixes to make sure existing dashboards can be used with custom index names. Also, the test coverage was increased as it is a quite big PR. The PR also decodes a few fields to make dashboards easier to review. ## Why is it important? The bug prevents users from setting custom index names and use our dashboards at the same time. Closes elastic#21232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new check to
make checkto make sure all dashboards can handle custom index names. It is the responsibility of the dashboard author to keep the dashboard useable ifsetup.dashboards.indexis configured.The PR contains additional fixes to make sure existing dashboards can be used with custom index names. Also, the test coverage was increased as it is a quite big PR.
The PR also decodes a few fields to make dashboards easier to review.
Why is it important?
The bug prevents users from setting custom index names and use our dashboards at the same time.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #21232