Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oracle Module] Refactor module to properly use host parsers instead of doing its own parsing of hosts #31611

Closed
Tracked by #30810
yug-rajani opened this issue May 12, 2022 · 0 comments · Fixed by #31692
Assignees
Labels
Team:Service-Integrations Label for the Service Integrations team

Comments

@yug-rajani
Copy link
Contributor

yug-rajani commented May 12, 2022

Problem

Oracle Metricbeat Module currently does its own parsing of hosts instead of using host parsers. Metricsets should rely on the host available in HostData.
For example,
If we look to the postgresql module, the url parser receives a single url to parse, and returns a single HostData, that contains a single host and is used like this by the metricset (here), without having to check the raw host configuration.

Solution

Metricbeat should instantiate one metricset per host, and the metricset shouldn't need to do any special handling to support multiple hosts. This module needs to be refactored to properly use host parsers instead of doing its own parsing of hosts. Using HostData is the only way a metricset instance has to know what host to use when multiple hosts are configured.

Use cases

  • When parsing the configured host, it allows to set in the HostData the Host, that is later used for service.address.
  • It abstracts the handling of multiple hosts, each metricset instance receives a single HostData with the host they have to use.

Related Converations

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2022
@yug-rajani yug-rajani self-assigned this May 20, 2022
@yug-rajani yug-rajani added the Team:Service-Integrations Label for the Service Integrations team label May 23, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
1 participant