[Oracle Module] Refactor module to properly use host parsers instead of doing its own parsing of hosts

[yug-rajani]

• Enhancement

What does this PR do?

Refactors the Oracle module to properly use host parsers instead of doing its own parsing of hosts.

Why is it important?

Metricbeat should instantiate one metricset per host, and the metricset shouldn't need to do any special handling to support multiple hosts. Using HostData is the only way a metricset instance has to know what host to use when multiple hosts are configured. When parsing the configured host, it allows to set in the HostData the Host, that is later used for service.address. It abstracts the handling of multiple hosts, each metricset instance receives a single HostData with the host they have to use.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have made corresponding change to the default configuration files
  - [ ] I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Closes [Oracle Module] Refactor module to properly use host parsers instead of doing its own parsing of hosts #31611

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-06-01T02:16:47.516+0000

• Duration: 59 min 41 sec

Test stats 🧪

Test	Results
Failed	0
Passed	1068
Skipped	91
Total	1159

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kush-elastic]

Just a small comment.
Rest LGTM!
Please wait for the others approvals.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b oracle_refactor_host_parsing upstream/oracle_refactor_host_parsing
git merge upstream/main
git push upstream oracle_refactor_host_parsing

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b oracle_refactor_host_parsing upstream/oracle_refactor_host_parsing
git merge upstream/main
git push upstream oracle_refactor_host_parsing

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b oracle_refactor_host_parsing upstream/oracle_refactor_host_parsing
git merge upstream/main
git push upstream oracle_refactor_host_parsing

[agithomas]

Please revisit the testing.go.
Please refer other modules such as mysql / cockroachdb.

[yug-rajani]

Please revisit the testing.go. Please refer other modules such as mysql / cockroachdb.

As a part of this PR, we are refactoring the host parsing mechanism of the Oracle Module, and based on our analysis, there does not seem to be a change required in the tests with respect to the changes we have made in the module. The testing.go (link) file of the module was developed along with the previous implementation (in which a single host is being passed as expected) and the same tests are passing with respect to the changes in this PR.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b oracle_refactor_host_parsing upstream/oracle_refactor_host_parsing
git merge upstream/main
git push upstream oracle_refactor_host_parsing

[agithomas]

Looks good to me.