-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom SSL config seems broken #8979
Comments
andrewvc
added a commit
to andrewvc/beats
that referenced
this issue
Nov 8, 2018
We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it.
I think this may have been a false positive. The test I added in #8984 seems to show that this feature works. Closing for now. |
andrewvc
added a commit
that referenced
this issue
Nov 12, 2018
* Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm #8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * Remove extraneous comment
andrewvc
added a commit
to andrewvc/beats
that referenced
this issue
Dec 19, 2018
* Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * Remove extraneous comment (cherry picked from commit 17d94b9)
andrewvc
added a commit
that referenced
this issue
Dec 20, 2018
* Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm #8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * Remove extraneous comment (cherry picked from commit 17d94b9)
andrewvc
added a commit
to andrewvc/beats
that referenced
this issue
Dec 21, 2018
) * Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * Remove extraneous comment (cherry picked from commit 17d94b9)
andrewvc
added a commit
that referenced
this issue
Dec 30, 2018
…ore/notAfter (#9759) * Add heartbeat test for TLS client cert auth (#8984) (#9676) * Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm #8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * [Heartbeat] Handle TLS certs missing notBefore/notAfter (#9566) Some certs in the wild don't set these standard fields and can cause an NPE Fixes #9556
leweafan
pushed a commit
to leweafan/beats
that referenced
this issue
Apr 28, 2023
… notBefore/notAfter (elastic#9759) * Add heartbeat test for TLS client cert auth (elastic#8984) (elastic#9676) * Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * [Heartbeat] Handle TLS certs missing notBefore/notAfter (elastic#9566) Some certs in the wild don't set these standard fields and can cause an NPE Fixes elastic#9556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to https://discuss.elastic.co/t/heartbeat-config-advice/155611 using a custom SSL configuration is currently broken. We should investigate this and ensure that we have a test for this scenario.
The text was updated successfully, but these errors were encountered: