Add heartbeat test for TLS client cert auth #8984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it.
ruflin
reviewed
Nov 8, 2018
| if extraConfig != nil { | ||
| for k, v := range extraConfig { | ||
| configSrc[k] = v | ||
| //configSrc["ssl.certificate_authorities"] = certPath |
There was a problem hiding this comment.
I've removed this. LGTM now?
ruflin
approved these changes
Nov 11, 2018
ruflin
approved these changes
Nov 12, 2018
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Dec 19, 2018
* Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * Remove extraneous comment (cherry picked from commit 17d94b9)
andrewvc
added a commit
that referenced
this pull request
Dec 20, 2018
* Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm #8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * Remove extraneous comment (cherry picked from commit 17d94b9)
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Dec 21, 2018
) * Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * Remove extraneous comment (cherry picked from commit 17d94b9)
andrewvc
added a commit
that referenced
this pull request
Dec 30, 2018
…ore/notAfter (#9759) * Add heartbeat test for TLS client cert auth (#8984) (#9676) * Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm #8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * [Heartbeat] Handle TLS certs missing notBefore/notAfter (#9566) Some certs in the wild don't set these standard fields and can cause an NPE Fixes #9556
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… notBefore/notAfter (elastic#9759) * Add heartbeat test for TLS client cert auth (elastic#8984) (elastic#9676) * Add heartbeat test for TLS client cert auth We were missing a test for this specific case. I wrote this hoping to confirm elastic#8979, but actually wound up disproving it. That said, this is still a good test to have, so we should merge it. * [Heartbeat] Handle TLS certs missing notBefore/notAfter (elastic#9566) Some certs in the wild don't set these standard fields and can cause an NPE Fixes elastic#9556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing a test for this specific case. I wrote this hoping to confirm #8979, but actually wound up disproving it.
That said, this is still a good test to have, so we should merge it.