Cherry-pick #9566 to 6.x: [Heartbeat] Handle TLS certs missing notBefore/notAfter #9758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This backport also includes the commit from #8984 to make the cherry pick possible. Since that was a test-only change I think it's very safe. |
ruflin
requested changes
Dec 27, 2018
CHANGELOG.asciidoc
Outdated
|
|
||
| *Affecting all Beats* | ||
|
|
||
| - Enforce validation for the Central Management access token. {issue}9621[9621] |
There was a problem hiding this comment.
Sounds like this cahngelog contains quite a bit more then expected.
There was a problem hiding this comment.
Yep, argh. I'll switch to changelog.next . Changelog merges never work right
* [Heartbeat] Handle TLS certs missing notBefore/notAfter Some certs in the wild don't set these standard fields and can cause an NPE Fixes elastic#9556 * Add changelog entry (cherry picked from commit 337113e)
andrewvc
force-pushed
the
backport_9566_6.x
branch
from
6f34e2f
to
66e5cf3
Compare
|
@ruflin rebased and fixed the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9566 to 6.x branch. Original message:
Some certs in the wild don't set these standard fields and can cause an NPE. I left a long comment in the code, this is sort of a bizarre situation.
Fixes #9556