Teach elasticsearch/audit fileset to parse out some more fields #10137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
enhancement
in progress
|
Pinging @elastic/stack-monitoring |
ycombinator
changed the title
ycombinator
added
review
and removed
in progress
ruflin
approved these changes
Jan 18, 2019
| "field": "message", | ||
| "pattern_definitions": { | ||
| "ES_TIMESTAMP": "\\[%{TIMESTAMP_ISO8601:elasticsearch.audit.timestamp}\\]", | ||
| "ES_NODE_NAME": "(\\[%{DATA:elasticsearch.node.name}\\])?", |
There was a problem hiding this comment.
I quite like what you did here with the pattern definitions. It makes the grok pattern more readable.
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Jan 24, 2019
… out some more fields (#10271) * Teach elasticsearch/audit fileset to parse out some more fields (#10137) * Be more lenient in parsing node name * Parse out elasticsearch.audit.realm * Adding CHANGELOG entry * Parse out elasticsearch.audit.roles * Parse out elasticsearch.audit.indices * Parse out optional sub-action * Regenerating generated files * Regenerating generated files (cherry picked from commit 210460e) * Regenerating generated files * Fixing types from array => keyword
ycombinator
added
v6.6.1
needs_backport
ycombinator
added
needs_backport
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Feb 1, 2019
… out some more fields (#10484) Cherry-pick of PR #10137 to 6.6 branch. Original message: Resolves #10134. This PR teaches the `elasticsearch/audit` fileset to parse out a few more fields, viz: * `elasticsearch.audit.realm`, * `elasticsearch.audit.roles` * `elasticsearch.audit.indices` It also teaches the fileset to parse `elasticsearch.audit.action` values that themselves contain `[` and `]` delimiters around sub-actions, e.g. `action=[indices:data/read/search[free_context]]`.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…o parse out some more fields (elastic#10484) Cherry-pick of PR elastic#10137 to 6.6 branch. Original message: Resolves elastic#10134. This PR teaches the `elasticsearch/audit` fileset to parse out a few more fields, viz: * `elasticsearch.audit.realm`, * `elasticsearch.audit.roles` * `elasticsearch.audit.indices` It also teaches the fileset to parse `elasticsearch.audit.action` values that themselves contain `[` and `]` delimiters around sub-actions, e.g. `action=[indices:data/read/search[free_context]]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10134.
This PR teaches the
elasticsearch/auditfileset to parse out a few more fields, viz:elasticsearch.audit.realm,elasticsearch.audit.roleselasticsearch.audit.indicesIt also teaches the fileset to parse
elasticsearch.audit.actionvalues that themselves contain[and]delimiters around sub-actions, e.g.action=[indices:data/read/search[free_context]].