-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #10137 to 6.x: Teach elasticsearch/audit fileset to parse out some more fields #10271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
requested changes
Jan 23, 2019
* Be more lenient in parsing node name * Parse out elasticsearch.audit.realm * Adding CHANGELOG entry * Parse out elasticsearch.audit.roles * Parse out elasticsearch.audit.indices * Parse out optional sub-action * Regenerating generated files * Regenerating generated files (cherry picked from commit 210460e)
ycombinator
force-pushed
the
backport_10137_6.x
branch
from
January 23, 2019 21:22
addfb6d
to
50d0d44
Compare
@ruflin I've fixed the I will put up separate PRs for fixing other |
cachedout
approved these changes
Jan 23, 2019
jenkins, test this |
jenkins, test this |
2 similar comments
jenkins, test this |
jenkins, test this |
ruflin
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #10137 to 6.x branch. Original message:
Resolves #10134.
This PR teaches the
elasticsearch/audit
fileset to parse out a few more fields, viz:elasticsearch.audit.realm
,elasticsearch.audit.roles
elasticsearch.audit.indices
It also teaches the fileset to parse
elasticsearch.audit.action
values that themselves contain[
and]
delimiters around sub-actions, e.g.action=[indices:data/read/search[free_context]]
.