Cherry-pick #10341 to 6.x: server Metricset for Zookeeper Metricbeat module #10375
Conversation
(cherry picked from commit 3895a23) # Conflicts: # metricbeat/module/zookeeper/fields.go # x-pack/metricbeat/module/mssql/performance/data_integration_test.go
|
You probably have to adjust test_zookeeper a bit as it also checks for service field which was not around in 6.x yet. Also regenerate the data.json files as the content might look a bit different. |
| @@ -71,7 +71,6 @@ def test_output(self): | |||
| self.assertEqual(len(output), 1) | |||
| evt = output[0] | |||
|
|
|||
| self.assertItemsEqual(self.de_dot(ZK_FIELDS), evt.keys()) | |||
There was a problem hiding this comment.
I see you remove this line. What were the errors you got? Perhaps there is an eays way to fix it instead of removing it.
There was a problem hiding this comment.
Error in Travis was pointing directly to this line which was pointing to a service field (service.name to be precise) that wasn't found. As far as I saw, this field comes from https://github.com/elastic/beats/blob/master/metricbeat/tests/system/metricbeat.py#L9 with this value
COMMON_FIELDS = ["@timestamp", "beat", "metricset.name", "metricset.host",
"metricset.module", "metricset.rtt", "host.name", "event"]A way to fix this is to use a customized COMMON_FIELDS which doesn't seem very ideal. But in any case I'm not sure if it should contain a service.name or not
There was a problem hiding this comment.
I think what should work here is:
self.assertItemsEqual(self.de_dot(ZK_FIELDS + ["sevice"]), evt.keys())
There was a problem hiding this comment.
Yeah, that's customized way but I'm a bit afraid that it could bite us in the future (by getting outdated somehow).
Anyways, test passes with that error but now I get a Key 'service.version' found in event is not documented which is true but I don't understand why CI hasn't detected it in master 😕
There was a problem hiding this comment.
I think I'm really confused because service.version is a ECS field, right? And it's not backported to 6.x AFAIK. But what should I do, update it in fields.yml of... where? 😄
There was a problem hiding this comment.
ECS is not in 6.x. The best way here as it's not used anywhere else is to add service.version to the zookeeper module (not fileset).
There was a problem hiding this comment.
For the outdated part: I would not worry too much as I don't expect many more changes will end up in 6.7 and if it gets outdated, CI will tell us.
|
@ruflin Friendly reminder here 🙂 |
Cherry-pick of PR #10341 to 6.x branch. Original message:
The current metricset uses the
srvr4 letter word command from Zookeeper to extract server information. Includes all the fields that are returned from the mentioned call. It looks like the following:You can see how the output is gonna look like in the data.json file.
A better description of the fields is missing. I have just written what I guess what they are but I might be wrong. I'm trying to find a good source of documentation to write a proper description of them.
GA
data.jsonexists and an automated way to generate it exists (go test -data)