Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server_integration_test.go version_date #10420

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix server_integration_test.go version_date #10420

merged 1 commit into from
Jan 30, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

--- FAIL: TestFetch (2.03s)
server_integration_test.go:47: zookeeper/server event: {RootFields:{"service":{"version":"3.4.8--1"}} ModuleFields:null MetricSetFields:{"connections":1,"count":0,"epoch":0,"latency":{"avg":0,"max":0,"min":0},"mode":"standalone","node_count":4,"outstanding":0,"received":1,"sent":0,"version_date":"02/06/2016 03:18 GMT","zxid":"0x0"} Index: ID: Namespace: Timestamp:0001-01-01 00:00:00 +0000 UTC Error: Host: Service: Took:0s}
server_integration_test.go:51:
Error Trace: server_integration_test.go:51
Error: Not equal:
expected: "06/29/2018 04:05 GMT"
actual : "02/06/2016 03:18 GMT"

                        Diff:
                        --- Expected
                        +++ Actual
                        @@ -1 +1 @@
                        -06/29/2018 04:05 GMT
                        +02/06/2016 03:18 GMT
        Test:           TestFetch

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner January 30, 2019 00:09
@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Jan 30, 2019
@ruflin
Copy link
Member

ruflin commented Jan 30, 2019

jenkins, test this

ruflin
ruflin reviewed Jan 30, 2019
View reviewed changes
metricbeat/module/zookeeper/server/server_integration_test.go
@@ -48,7 +48,7 @@ func TestFetch(t *testing.T) {
metricsetFields := event.MetricSetFields

// Check values
assert.Equal(t, "06/29/2018 04:05 GMT", metricsetFields["version_date"])
assert.Equal(t, "02/06/2016 03:18 GMT", metricsetFields["version_date"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayden Any idea on why this might have changed? Perhaps we should compare some other fields in the tests as this one changes every time we update the docker image I assume.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because I was using the official image with 3.4.13 instead of the unofficial configured one in the Dockerfile jplock/zookeeper:3.4.8.

But, yes, we can just compare other fields and maintain current image.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why was the build green here? #10341

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering the same, also with this error #10375 (comment)

@ruflin ruflin added the review label Jan 30, 2019
@ruflin ruflin merged commit 55c5523 into elastic:master Jan 30, 2019
@ruflin
Copy link
Member

ruflin commented Jan 30, 2019

@kaiyan-sheng Merged to get our builds back to green. Thanks for the fix.

@kaiyan-sheng kaiyan-sheng deleted the fix_zookeeper_test branch January 30, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden left review comments

@ruflin ruflin ruflin left review comments

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @ruflin @sayden