Skip password test in metricbeat redis module #11243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, docker containers are shared between tests. Password test changes the password as part of its checks, what can affect the connection of other tests using the same instance, skip this test by now to avoid flakiness in the rest of tests.
jsoriano
added
module
review
Metricbeat
ruflin
approved these changes
Mar 14, 2019
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 21, 2019
At the moment, docker containers are shared between tests. Password test changes the password as part of its checks, what can affect the connection of other tests using the same instance, skip this test by now to avoid flakiness in the rest of tests. (cherry picked from commit b1f36ce)
jsoriano
added a commit
that referenced
this pull request
Mar 21, 2019
At the moment, docker containers are shared between tests. Password test changes the password as part of its checks, what can affect the connection of other tests using the same instance, skip this test by now to avoid flakiness in the rest of tests. (cherry picked from commit b1f36ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, docker containers are shared between tests. Password test
changes the password as part of its checks, what can affect the
connection of other tests using the same instance, skip this test by
now to avoid flakiness in the rest of tests.
#7957 will run each package on a different docker compose scenario, what
will help to control this kind of interactions.