Skip to content

Commit

Permalink
Skip password test in metricbeat redis module (elastic#11243)
Browse files Browse the repository at this point in the history
At the moment, docker containers are shared between tests. Password test
changes the password as part of its checks, what can affect the
connection of other tests using the same instance, skip this test by
now to avoid flakiness in the rest of tests.

(cherry picked from commit b1f36ce)
  • Loading branch information
jsoriano committed Mar 21, 2019
1 parent f0ba5d6 commit 81173be
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions metricbeat/module/redis/info/info_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ func TestFetch(t *testing.T) {
if err != nil {
t.Fatal("fetch", err)
}
if len(events) == 0 {
t.Fatal("no events")
}
event := events[0].MetricSetFields

t.Logf("%s/%s event: %+v", ms.Module().Name(), ms.Name(), event)
Expand Down
2 changes: 2 additions & 0 deletions metricbeat/module/redis/metricset_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const (
)

func TestPasswords(t *testing.T) {
t.Skip("Changing password affects other tests, see https://github.com/elastic/beats/issues/10955")

compose.EnsureUp(t, "redis")

registry := mb.NewRegister()
Expand Down

0 comments on commit 81173be

Please sign in to comment.