Fix template/policy is always overwritten #11671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The force flag for policy and template overwrites have been set to true in the standard Elasticsearch callback. Due to this every reconnect will result in the policy and template being overwritten. This fix sets the flags to false and ensure that the template is only overwritten if a new policy is created in Elasticsearch.
odacremolbap
reviewed
Apr 5, 2019
odacremolbap
reviewed
Apr 5, 2019
odacremolbap
reviewed
Apr 5, 2019
odacremolbap
reviewed
Apr 5, 2019
odacremolbap
reviewed
Apr 5, 2019
|
Is this related to this issue ? #11594 |
|
@alvarolobato I'd say yes. The fact that user has configured template overwrite to |
added 2 commits
April 5, 2019 17:50
urso
pushed a commit
that referenced
this pull request
Apr 5, 2019
…11672) Cherry-pick of PR #11671 to 7.0 branch. Original message: The force flag for policy and template overwrites have been set to true in the standard Elasticsearch callback. Due to this every reconnect will result in the policy and template being overwritten. This fix sets the flags to false and ensure that the template is only overwritten if a new policy is created in Elasticsearch.
ph
approved these changes
Apr 5, 2019
graphaelli
added a commit
to elastic/apm-server
that referenced
this pull request
Apr 5, 2019
* Fix index template always being overwritten - elastic/beats#11671 * Perform Basic license check on Elasticsearch connect - elastic/beats#11296 + elastic/beats#11649
|
Original issue #11668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The force flag for policy and template overwrites have been set to true
in the standard Elasticsearch callback. Due to this every reconnect will
result in the policy and template being overwritten.
This fix sets the flags to false and ensure that the template is only
overwritten if a new policy is created in Elasticsearch.