Listen explicitly on localhost on heartbeat TCP tests #15583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were requiring localhost to resolve to 127.0.0.1, but this is not always the case. In some machines localhost resolve to other local addresses as 127.0.1.1, or to [::1] if ipv4 is not available.
63 tasks
jsoriano
commented
Jan 15, 2020
| @@ -1,5 +1,5 @@ | |||
| Elastic Beats | |||
| Copyright 2014-2019 Elasticsearch BV | |||
| Copyright 2014-2020 Elasticsearch BV | |||
There was a problem hiding this comment.
Not related to this change but required in the python 3 branch.
kvch
approved these changes
Jan 15, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Some tests were requiring localhost to resolve to 127.0.0.1, but this is not always the case. In some machines localhost resolve to other local addresses as 127.0.1.1, or to [::1] if ipv4 is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were requiring localhost to resolve to 127.0.0.1, but this is
not always the case. In some machines localhost resolve to other local
addresses as 127.0.1.1, or to [::1] if ipv4 is not available.
httptest.NewServeralways binds to127.0.0.1, so connections tolocalhost can fail if localhost resolves to a different IP.
Explicitly use
localhostwhen binding and later expecting name resolution.Issue seen in Travis when upgrading the Ubuntu image during the
migration to Python 3, can be reproduced by modifying
/etc/hoststouse an IP different to
127.0.0.1aslocalhost.