Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Libbeat] Remove global logger from libbeat publisher and reader #16886

Merged
merged 1 commit into from
Mar 9, 2020
Merged

[Libbeat] Remove global logger from libbeat publisher and reader #16886

merged 1 commit into from
Mar 9, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

What does this PR do?

This PR is to remove global logger for libbeat/publisher and libbeat/reader as a part of #15699.

@urso urso mentioned this pull request Mar 6, 2020
Closed
66 tasks
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 6, 2020
@andresrc andresrc added [zube]: Inbox Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Mar 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

blakerouse
blakerouse approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

sayden
sayden approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaiyan-sheng kaiyan-sheng merged commit ad2672d into elastic:master Mar 9, 2020
@kaiyan-sheng kaiyan-sheng deleted the logging_refactor branch March 9, 2020 19:27
@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 9, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request Mar 10, 2020
@kaiyan-sheng
Revert "Remove global logger from libbeat publisher and reader (#16886)"
919c9f0 
This reverts commit ad2672d.
This was referenced Mar 10, 2020
Closed
Merged
kaiyan-sheng added a commit that referenced this pull request Mar 17, 2020
@kaiyan-sheng
Cherry-pick #16886 to 7.x: [Libbeat] Remove global logger from libbea…
02d3c70 
…t publisher and reader (#16912)

* Remove global logger from libbeat publisher and reader (#16886)


(cherry picked from commit ad2672d)

* backport #16915 in this PR
@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

@blakerouse blakerouse blakerouse approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Platforms Label for the Integrations - Platforms team Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaiyan-sheng @elasticmachine @blakerouse @sayden @andresrc