Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16915 to 7.x: Add missing logger init in New() functions #17087

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Cherry-pick #16915 to 7.x: Add missing logger init in New() functions #17087

merged 1 commit into from
Mar 18, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 18, 2020

Cherry-pick of PR #16915 to 7.x branch. Original message:

This PR fixes #16886 by adding init loggers in New() functions.

Note:
This is to fix the partial manual cherrypick I did in #16912.

* Add missing logger init in New() functions

(cherry picked from commit e64a18f)
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WFG.

@kaiyan-sheng kaiyan-sheng merged commit 2cd1212 into elastic:7.x Mar 18, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_16915_7.x branch March 18, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants